-
Notifications
You must be signed in to change notification settings - Fork 5.3k
Allocate string literals on frozen segments #49576
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
69 commits
Select commit
Hold shift + click to select a range
166ccfe
Naive implementation of FrozenObjectHeap
EgorBo 1cb0927
Add RegisterFrozenSegment
EgorBo d2b9cbf
Clean up
EgorBo 641365a
Add #include "common.h"
EgorBo 33a126b
Fix build error
EgorBo bb1b835
Fix build
EgorBo 2ef204a
Add lock
EgorBo a84a6ee
Clean up
EgorBo 142295a
init memory on first allocation
EgorBo a446dd6
Clean up
EgorBo 41665c3
revert changes in emitxarch.cpp
EgorBo 66d6106
Merge branch 'main' of github.com:dotnet/runtime into poh-string-lite…
EgorBo 67f32a7
Update branch, fix asserts
EgorBo 9ecf7d7
fix release build
EgorBo 45a454a
Ignore collectible assemblies, fix build
EgorBo 1d0a710
Fix failing tests, address feedback
EgorBo 201565e
Rename bAppDomainWontUnload to bIsCollectible
EgorBo c7dad85
Address feedback
EgorBo 4202d9f
Clean up
EgorBo 69ab9d2
Merge branch 'main' of github.com:dotnet/runtime into poh2
EgorBo a144453
Fix assert
EgorBo 2571c9c
Fix more asserts not expecting TYP_REF constants being non zero
EgorBo 286f8ab
Merge branch 'main' of github.com:dotnet/runtime into poh2
EgorBo 28e0331
Test gc fix
EgorBo 6625759
move check to IsEphemeral
EgorBo 89df356
Test commit (do I need to update "ibAllocated"?)
EgorBo 3cb98e9
Implement commit-on-demand
EgorBo c6df9ed
Clean up
EgorBo f50b4b9
bump FOH_COMMIT_PAGES
EgorBo 2b55835
Merge branch 'main' of github.com:dotnet/runtime into poh2
EgorBo 6ea2a50
Address feedback, clean up
EgorBo 15ca880
Fix build
EgorBo 193676e
Merge branch 'main' of github.com:dotnet/runtime into poh2
EgorBo 9198043
Unix's ClrVirtualAlloc seems to be non-aligned
EgorBo 7c98ef2
Oops, fix red CI
EgorBo af6e445
Multiple frozen segments
EgorBo 2183c2f
Merge branch 'main' of github.com:dotnet/runtime into poh2
EgorBo 4ef34dd
Clean up
EgorBo 722eb82
fix typo
EgorBo 0ae890a
Fix assert in assertionprop.cpp
EgorBo e59d27a
Address feedback
EgorBo 90feb96
Merge branch 'main' of github.com:dotnet/runtime into poh-string-lite…
EgorBo ce3e19e
Merge branch 'main' of github.com:dotnet/runtime into poh-string-lite…
EgorBo b6fae80
Address feedback
EgorBo 32cb338
Merge branch 'main' of github.com:dotnet/runtime into poh-string-lite…
EgorBo d20cc47
Address feedback
EgorBo 31b5fdc
Fix potential issues
EgorBo 1b1ab4c
Fix potential issues
EgorBo ed8ed7b
Merge branch 'main' of github.com:dotnet/runtime into poh-string-lite…
EgorBo 88ad320
Address feedback
EgorBo 943a235
Address feedback
EgorBo a3bfc8c
Check if this fixes all asserts
EgorBo 1be12c5
Handle string.Empty (it used to be ignored)
EgorBo 5c2a222
Apply suggestions from code review
EgorBo 19d1734
Address feedback
EgorBo 4762bcc
Address feedback
EgorBo 2e03cc2
Update src/coreclr/vm/stringliteralmap.cpp
EgorBo 2f00f71
Update src/coreclr/vm/stringliteralmap.cpp
EgorBo ddfbf73
fix compilation errors
EgorBo 598b9c8
Merge branch 'main' of github.com:dotnet/runtime into poh-string-lite…
EgorBo 802106e
Address Jan's feedback
EgorBo bfe96e7
Update src/coreclr/jit/gentree.cpp
EgorBo 2e10c9c
Update gentree.cpp
EgorBo 3415dc3
Merge branch 'main' of github.com:dotnet/runtime into poh-string-lite…
EgorBo bac0389
Address Maoni's feedback:
EgorBo 01b5731
heap -> segment in comments
EgorBo 8d139c9
Update src/coreclr/vm/frozenobjectheap.h
EgorBo b6deb3c
Address Jan's feedback around m_Crst creation
EgorBo 1ba9d97
Fix order of initialization
EgorBo File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Fix build
- Loading branch information
commit bb1b8359647cd9fcb4052bb7f1209ca9a635b434
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.