Fix SHL/SHR/SAR PerfScores #49620
Merged
Fix SHL/SHR/SAR PerfScores #49620
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
area-CodeGen-coreclr
briansull
reviewed
Mar 15, 2021
Fix some RCR/RCL latencies also.
briansull
reviewed
Mar 16, 2021
sandreenko
approved these changes
Apr 2, 2021
Contributor
sandreenko
left a comment
sandreenko
left a comment
There was a problem hiding this comment.
LGTM, Brian would be a better person to sign off but he is oof now.
Contributor
Author
|
So this can be merged? I don't have write access to the repo. |
Contributor
sure, just wanted to give others a few days to add feedback if they had it. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While doing diffs for #49585 I noticed that SHR PerfScores were way off:
shr reg, clcosts were assigned toshr reg, constinstructions.mul/imullatencies to reflect actual use cases.