Skip to content

[QUIC] API Update #49823

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ManickaP merged 15 commits into from
Mar 26, 2021
Merged

[QUIC] API Update #49823

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
6bf36e4
Cherry picked change from scalablecory/msquic-update.
ManickaP Mar 12, 2021
e96522e
Enum rename _FLAG --> _FLAGS to follow msquic naming.
ManickaP Mar 12, 2021
b92bd1d
Enums updated
ManickaP Mar 12, 2021
7aa745c
Updated interop, compilable project.
ManickaP Mar 13, 2021
6a132c5
Somewhat working update of msquic API
ManickaP Mar 17, 2021
1d0d98c
Merge main
ManickaP Mar 17, 2021
68a5c48
Post-merge compilation fixes.
ManickaP Mar 17, 2021
851dc1b
Fixed most of the tests, one turned into ActiveIssue
ManickaP Mar 17, 2021
78e3981
Comments.
ManickaP Mar 18, 2021
7ad5163
Regenerated ref sources.
ManickaP Mar 18, 2021
f67ed0d
Addressed some feedback.
ManickaP Mar 19, 2021
204f4fa
Added readme.
ManickaP Mar 23, 2021
72ea176
Merge branch 'main' into mapichov/44580_quic_update
ManickaP Mar 25, 2021
5d3884f
QUIC_ADDRESS_FAMILY
ManickaP Mar 25, 2021
c0f896f
Merge branch 'main' into mapichov/44580_quic_update
ManickaP Mar 26, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Post-merge compilation fixes.
  • Loading branch information
@ManickaP
ManickaP committed Mar 17, 2021
commit 68a5c485c423570d699a8d43690b77ab4229a35f
4 changes: 2 additions & 2 deletions src/libraries/System.Net.Quic/src/System/Net/Quic/Implementations/Mock/MockConnection.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,8 +91,8 @@ internal override bool Connected
}

// TODO: Should clone the endpoint since it is mutable
// TODO: could this be made back to non-nullable?
// For inbound we have it immidiatelly, for outbound after connect.
// TODO: could this be made back to non-nullable?
Copy link
Contributor

@scalablecory scalablecory Mar 25, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we get rid of instance method ConnectAsync and make a static ValueTask<QuicConnection> QuicConnection.ConnectAsync(), then we can always have LocalEndPoint be non-null.

Copy link
Member Author

@ManickaP ManickaP Mar 25, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I consider the TODO as work that needs to be done/resolved. But I don't want to hold the PR on those issues. The work will be done in follow up PRs.

// For inbound we have it immediately, for outbound after connect.
internal override IPEndPoint? LocalEndPoint => _localEndPoint;

// TODO: Should clone the endpoint since it is mutable
Expand Down
6 changes: 3 additions & 3 deletions src/libraries/System.Net.Quic/tests/FunctionalTests/System.Net.Quic.Functional.Tests.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,14 +8,14 @@
<Compile Include="*.cs" />
</ItemGroup>
<ItemGroup>
<Compile Include="$(CommonTestPath)System\Net\Configuration.Certificates.cs" Link="Common\System\Net\Configuration.Certificates.cs" />
<Compile Include="$(CommonTestPath)System\IO\ConnectedStreams.cs" Link="Common\System\IO\ConnectedStreams.cs" />
<Compile Include="$(CommonTestPath)System\Net\Configuration.Certificates.cs" Link="TestCommon\System\Net\Configuration.Certificates.cs" />
<Compile Include="$(CommonTestPath)System\Security\Cryptography\PlatformSupport.cs" Link="TestCommon\System\Security\Cryptography\PlatformSupport.cs" />
<Compile Include="$(CommonTestPath)System\Threading\Tasks\TaskTimeoutExtensions.cs" Link="TestCommon\System\Threading\Tasks\TaskTimeoutExtensions.cs" />
<Compile Include="$(CommonPath)System\Net\ArrayBuffer.cs" Link="ProductionCode\Common\System\Net\ArrayBuffer.cs" />
<Compile Include="$(CommonPath)System\Net\MultiArrayBuffer.cs" Link="ProductionCode\Common\System\Net\MultiArrayBuffer.cs" />
<Compile Include="$(CommonPath)System\Net\StreamBuffer.cs" Link="ProductionCode\Common\System\Net\StreamBuffer.cs" />
<Compile Include="$(CommonPath)System\Threading\Tasks\TaskToApm.cs" Link="Common\System\Threading\Tasks\TaskToApm.cs" />
</ItemGroup>
</ItemGroup>
<ItemGroup>
<ProjectReference Include="$(CommonTestPath)StreamConformanceTests\StreamConformanceTests.csproj" />
</ItemGroup>
Expand Down