Skip to content

Move type check to after the null ref branch in out marshalling of blittable classes. #50735

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jkoritzinsky merged 4 commits into from
Apr 7, 2021
Merged

Move type check to after the null ref branch in out marshalling of blittable classes. #50735

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
cdcc4b5
Move type check to after the null ref branch.
jkoritzinsky Apr 5, 2021
4934918
Add non-blittable null test.
jkoritzinsky Apr 5, 2021
bdfca2d
Remove extraneous paren.
jkoritzinsky Apr 5, 2021
3d20e06
Update src/tests/Interop/LayoutClass/LayoutClassTest.cs
jkoritzinsky Apr 6, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Remove extraneous paren.
  • Loading branch information
@jkoritzinsky
jkoritzinsky committed Apr 5, 2021
commit bdfca2d40f8b9826174d903ea772dff233e77dbc
2 changes: 1 addition & 1 deletion src/tests/Interop/LayoutClass/LayoutClassTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -217,7 +217,7 @@ public static void BlittableClassNull()
{
// [Compat] Marshalled with [In, Out] behaviour by default
Console.WriteLine($"Running {nameof(BlittableClassNull)}...");
Assert.IsTrue(SimpleBlittableSeqLayoutClass_Null(null)));
Assert.IsTrue(SimpleBlittableSeqLayoutClass_Null(null));
}

public static void BlittableClassByInAttr()
Expand Down