[release/6.0-preview4][wasm] Fix Blazor AOT builds inside Visual Studio #52078

lewing · 2021-04-29T21:15:28Z

Description

Fix Blazor AOT builds inside Visual Studio by multi-targeting the build tasks.

Customer Impact

Without these fixes the build fails when run inside Visual Studio causing that experience to be worse than other build methods (command line and VS Code)

Regression

No, these tasks are new in this release

Testing

Manual Testing against the 6.0.100-preview.4.21229.17 sdk and VS Version 16.10.0 Preview 2.1

Risk

Very Low. The changes only impact the AOT workload

- In case of `WasmAppBuilder.dll`, we were packaging only the task assembly, and `System.Reflection.MetadataLoadContext` for net472, same as net6.0 . - But for net472, VS fails with errors like: ``` C:\Program Files\dotnet\packs\Microsoft.NET.Runtime.WebAssembly.Sdk\6.0.0-preview.4.21222.10\Sdk\WasmApp.targets(424,4): Error MSB4018: The "PInvokeTableGenerator" task failed unexpectedly. System.IO.FileNotFoundException: Could not load file or assembly 'System.Reflection.Metadata, Version=1.4.5.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a' or one of its dependencies. The system cannot find the file specified. File name: 'System.Reflection.Metadata, Version=1.4.5.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a' at System.Reflection.MetadataLoadContext.LoadFromStreamCore(Stream peStream) at System.Reflection.MetadataLoadContext.LoadFromAssemblyPath(String assemblyPath) at System.Reflection.PathAssemblyResolver.Resolve(MetadataLoadContext context, AssemblyName assemblyName) at System.Reflection.MetadataLoadContext.TryFindAssemblyByCallingResolveHandler(RoAssemblyName refName) at System.Reflection.MetadataLoadContext.ResolveToAssemblyOrExceptionAssembly(RoAssemblyName refName) at System.Reflection.MetadataLoadContext.TryResolveAssembly(RoAssemblyName refName, Exception& e) at System.Reflection.MetadataLoadContext.TryGetCoreAssembly(String coreAssemblyName, Exception& e) at System.Reflection.TypeLoading.CoreTypes..ctor(MetadataLoadContext loader, String coreAssemblyName) at System.Reflection.MetadataLoadContext..ctor(MetadataAssemblyResolver resolver, String coreAssemblyName) at PInvokeTableGenerator.GenPInvokeTable(String[] pinvokeModules, String[] assemblies) in /Users/radical/dev/r2/src/tasks/WasmAppBuilder/PInvokeTableGenerator.cs:line 42 at PInvokeTableGenerator.Execute() in /Users/radical/dev/r2/src/tasks/WasmAppBuilder/PInvokeTableGenerator.cs:line 28 at Microsoft.Build.BackEnd.TaskExecutionHost.Microsoft.Build.BackEnd.ITaskExecutionHost.Execute() at Microsoft.Build.BackEnd.TaskBuilder.<ExecuteInstantiatedTask>d__26.MoveNext() ``` - So, bundle all the dependent assemblies from the publish folder

ghost · 2021-04-29T21:15:33Z

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

src/tasks/Common/NotNullAttribute.cs

src/tasks/WasmAppBuilder/WasmAppBuilder.cs

ghost · 2021-04-30T17:57:36Z

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

Description

Fix Blazor AOT builds inside Visual Studio by multi-targeting the build tasks.

Customer Impact

Without these fixes the build fails when run inside Visual Studio causing that experience to be worse than other build methods (command line and VS Code)

Regression

No, these tasks are new in this release

Testing

Manual Testing against the 6.0.100-preview.4.21229.17 sdk and VS Version 16.10.0 Preview 2.1

Risk

Very Low. The changes only impact the AOT workload

Author:	lewing
Assignees:	-
Labels:	`Servicing-consider`, `arch-wasm`, `area-Build-mono`
Milestone:	-

src/tasks/AotCompilerTask/MonoAOTCompiler.csproj

src/tasks/WasmAppBuilder/WasmAppBuilder.csproj

dsplaisted · 2021-04-30T18:47:02Z

src/tasks/WasmAppBuilder/WasmAppBuilder.csproj

+    <!-- needed for publishing with multi-targeting. We are publishing essentially to get the SR.MetadataLoadContext.dll :/ -->
+    <ItemGroup>
+      <_PublishFramework Include="$(TargetFrameworks)" />
+    </ItemGroup>
+    <MSBuild Projects="$(MSBuildProjectFile)" Targets="Publish" Properties="TargetFramework=%(_PublishFramework.Identity)" />


This looks a bit scary. Aren't the dependencies that need to be packaged included in the build output folder?

In case of net472, yes, but not for net6.0 :|

The existing code uses Publish target to get the assembly.

src/tasks/WasmAppBuilder/WasmAppBuilder.csproj

Co-authored-by: Daniel Plaisted <[email protected]>

lewing · 2021-04-30T20:23:53Z

Validated a local build of 2926086 packages successfully

* Port additional fixes in #52078 main * Update src/tasks/AotCompilerTask/MonoAOTCompiler.csproj Co-authored-by: Daniel Plaisted <[email protected]> * Update src/tasks/WasmAppBuilder/WasmAppBuilder.csproj Co-authored-by: Daniel Plaisted <[email protected]> * Update src/tasks/WasmAppBuilder/WasmAppBuilder.csproj Co-authored-by: Daniel Plaisted <[email protected]> * Apply suggestions from code review Co-authored-by: Daniel Plaisted <[email protected]> * Use a property for net472 * Use consistent separator character Co-authored-by: Adeel Mujahid <[email protected]> Co-authored-by: Ankit Jain <[email protected]> Co-authored-by: Daniel Plaisted <[email protected]> Co-authored-by: Adeel Mujahid <[email protected]>

lewing · 2021-05-03T17:39:17Z

Approved in email.

radical added 2 commits April 29, 2021 16:05

[wasm] Build tasks for net472 also (dotnet#51959)

81a7b06

lewing added the area-Build-mono label Apr 29, 2021

marek-safar reviewed Apr 30, 2021

View reviewed changes

src/tasks/Common/NotNullAttribute.cs Outdated Show resolved Hide resolved

marek-safar reviewed Apr 30, 2021

View reviewed changes

src/tasks/WasmAppBuilder/WasmAppBuilder.cs Outdated Show resolved Hide resolved

Address review feedback

7e36306

pranavkm approved these changes Apr 30, 2021

View reviewed changes

lewing changed the title ~~[testing][wasm] Backport task fixes for VS~~ [release/6.0-preview4][wasm] Fix Blazor AOT builds inside Visual Studio Apr 30, 2021

lewing added the Servicing-consider Issue for next servicing release review label Apr 30, 2021

lewing marked this pull request as ready for review April 30, 2021 17:57

lewing added the arch-wasm WebAssembly architecture label Apr 30, 2021

lewing pushed a commit to lewing/runtime that referenced this pull request Apr 30, 2021

Port additional fixes in dotnet#52078 main

fb67966

dsplaisted approved these changes Apr 30, 2021

View reviewed changes

radical and others added 6 commits April 30, 2021 14:59

Update src/tasks/AotCompilerTask/MonoAOTCompiler.csproj

ecf3fde

Co-authored-by: Daniel Plaisted <[email protected]>

Update src/tasks/AotCompilerTask/MonoAOTCompiler.csproj

3a578b4

Co-authored-by: Daniel Plaisted <[email protected]>

Update src/tasks/WasmAppBuilder/WasmAppBuilder.csproj

0952d57

Co-authored-by: Daniel Plaisted <[email protected]>

Update src/tasks/WasmAppBuilder/WasmAppBuilder.csproj

6a6cdf9

Co-authored-by: Daniel Plaisted <[email protected]>

Apply suggestions from code review

1161bab

Co-authored-by: Daniel Plaisted <[email protected]>

Use a property for net472

2926086

lewing added Servicing-approved Approved for servicing release and removed Servicing-consider Issue for next servicing release review labels May 3, 2021

mmitche merged commit bfd6048 into dotnet:release/6.0-preview4 May 3, 2021

lewing deleted the wasm-multitarget branch May 3, 2021 18:09

ghost locked as resolved and limited conversation to collaborators Jun 2, 2021

[release/6.0-preview4][wasm] Fix Blazor AOT builds inside Visual Studio #52078

[release/6.0-preview4][wasm] Fix Blazor AOT builds inside Visual Studio #52078

Uh oh!

Conversation

lewing commented Apr 29, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Customer Impact

Regression

Testing

Risk

Uh oh!

ghost commented Apr 29, 2021

Uh oh!

Uh oh!

Uh oh!

ghost commented Apr 30, 2021

Description

Customer Impact

Regression

Testing

Risk

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

dsplaisted Apr 30, 2021

Choose a reason for hiding this comment

Uh oh!

radical Apr 30, 2021

Choose a reason for hiding this comment

Uh oh!

radical Apr 30, 2021

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

lewing commented Apr 30, 2021

Uh oh!

lewing commented May 3, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

lewing commented Apr 29, 2021 •

edited

Loading