Skip to content

Annotate required APIs with DynamicallyAccessedMemberTypes.Interfaces #52461

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vitek-karas merged 9 commits into from
May 12, 2021
Merged

Annotate required APIs with DynamicallyAccessedMemberTypes.Interfaces #52461

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
df9b104
Annotate required APIs with DynamicallyAccessedMemberTypes.Interfaces
vitek-karas Apr 21, 2021
b0eda4c
Fix build
vitek-karas May 7, 2021
fece35b
Merge remote-tracking branch 'origin/main' into GetInterfacesAnnotation
vitek-karas May 10, 2021
3c62154
Merge with main and fix warnings in OOB packages
vitek-karas May 10, 2021
748a107
PR feedback
vitek-karas May 10, 2021
702bed0
Fix ref assemblies
vitek-karas May 11, 2021
379f848
Fix ref assemblies
vitek-karas May 11, 2021
1b7bf61
Annotate return value of GetInterface with Interfaces.
vitek-karas May 11, 2021
90c6fdf
Fix build issues on Linux
vitek-karas May 12, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Fix build issues on Linux
  • Loading branch information
@vitek-karas
vitek-karas committed May 12, 2021
commit 90c6fdf2ab2fdf3bb6134bd7fca23cd8751c2343
2 changes: 2 additions & 0 deletions src/mono/System.Private.CoreLib/src/System/Reflection/Emit/DerivedTypes.Mono.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -230,6 +230,8 @@ public override FieldInfo[] GetFields(BindingFlags bindingAttr)

[DynamicallyAccessedMembers(DynamicallyAccessedMemberTypes.Interfaces)]
[return: DynamicallyAccessedMembers(DynamicallyAccessedMemberTypes.Interfaces)]
[UnconditionalSuppressMessage("ReflectionAnalysis", "IL2063:UnrecognizedReflectionPattern",
Justification = "Linker doesn't recognize always throwing method. https://github.com/mono/linker/issues/2025")]
public override Type GetInterface(string name, bool ignoreCase)
{
throw new NotSupportedException(SR.NotSupported_NonReflectedType);
Expand Down
2 changes: 2 additions & 0 deletions src/mono/System.Private.CoreLib/src/System/Reflection/Emit/TypeBuilderInstantiation.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -442,6 +442,8 @@ protected override TypeAttributes GetAttributeFlagsImpl()
//stuff that throws
[DynamicallyAccessedMembers(DynamicallyAccessedMemberTypes.Interfaces)]
[return: DynamicallyAccessedMembers(DynamicallyAccessedMemberTypes.Interfaces)]
[UnconditionalSuppressMessage("ReflectionAnalysis", "IL2063:UnrecognizedReflectionPattern",
Justification = "Linker doesn't recognize always throwing method. https://github.com/mono/linker/issues/2025")]
public override Type GetInterface(string name, bool ignoreCase)
{
throw new NotSupportedException();
Expand Down