Skip to content

Fix WaitForConnectionAsync when NamedPipeServerStream is disposed #52825

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
stephentoub merged 8 commits into from
Jul 18, 2021
Merged

Fix WaitForConnectionAsync when NamedPipeServerStream is disposed #52825

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
bfb150e
Fix WaitForConnectionAsync when NamedPipeServerStream is disposed
manandre May 16, 2021
4c02549
Align Unix implementation on broken pipe IO exception as on Windows
manandre May 16, 2021
5ede4a3
Add missing methods to test against ObjectDisposedException
manandre May 16, 2021
7e5d486
Apply suggestions from code review
manandre May 26, 2021
64f7e78
Rebase and fix suggestions
manandre May 26, 2021
ef60a2f
Cancel Accept on dispose
manandre Jun 1, 2021
8a6e802
Improve test
manandre Jun 2, 2021
edf50b3
Apply suggestions from code review
stephentoub Jul 18, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add missing methods to test against ObjectDisposedException
  • Loading branch information
@manandre
manandre committed Jun 1, 2021
commit 5ede4a3999bbde196e76bf417159ee30e6b2b869
9 changes: 9 additions & 0 deletions src/libraries/System.IO.Pipes/tests/PipeStreamConformanceTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,6 +97,15 @@ protected sealed override async Task<StreamPair> CreateConnectedStreamsAsync()
return ((NamedPipeServerStream)streams.Stream2, (NamedPipeClientStream)streams.Stream1);
}

protected async Task ValidateDisposedExceptionsAsync(NamedPipeServerStream server)
{
Assert.Throws<ObjectDisposedException>(() => server.Disconnect());
Assert.Throws<ObjectDisposedException>(() => server.GetImpersonationUserName());
Assert.Throws<ObjectDisposedException>(() => server.WaitForConnection());
await Assert.ThrowsAsync<ObjectDisposedException>(() => server.WaitForConnectionAsync());
await ValidateDisposedExceptionsAsync(server as Stream);
}

/// <summary>
/// Yields every combination of testing options for the OneWayReadWrites test
/// </summary>
Expand Down