Skip to content

Fold System.IO.FileSystem into CoreLib #53231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
adamsitnik merged 12 commits into from
May 27, 2021
Merged

Fold System.IO.FileSystem into CoreLib #53231

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
4ffe5e9
move Queue<T> to System.Private.CoreLib
adamsitnik May 25, 2021
52dab09
fold System.IO.FileSystem into System.Private.CoreLib
adamsitnik May 25, 2021
72a7559
fix the Unix build
adamsitnik May 25, 2021
e8e5eb8
Merge remote-tracking branch 'upstream/main' into foldSystemIoFileSystem
adamsitnik May 25, 2021
6e35f8f
don't use EnumerableHelpers.ToArray, as the array returned by it migh…
adamsitnik May 26, 2021
41cca77
don't move Stack<T> into CoreLib, use List<T> instead
adamsitnik May 26, 2021
80ebe49
revert EnumerableHelpers changes that are not needed anymore
adamsitnik May 26, 2021
2e1bddd
Merge remote-tracking branch 'upstream/main' into foldSystemIoFileSystem
adamsitnik May 26, 2021
fd16ed1
not needed anymore
adamsitnik May 26, 2021
768cad0
address code review feedback
adamsitnik May 27, 2021
173b4c0
fix Mono build
adamsitnik May 27, 2021
d09c0b4
fix Windows build?
adamsitnik May 27, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
don't use EnumerableHelpers.ToArray, as the array returned by it migh… 
…t need shrinking
  • Loading branch information
@adamsitnik
adamsitnik committed May 26, 2021
commit 6e35f8f6a01dcc16a33661fc9d8b417bdbdc8027
6 changes: 3 additions & 3 deletions src/libraries/System.Private.CoreLib/src/System/IO/Directory.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,7 +143,7 @@ public static string[] GetFiles(string path, string searchPattern, SearchOption
=> GetFiles(path, searchPattern, EnumerationOptions.FromSearchOption(searchOption));

public static string[] GetFiles(string path, string searchPattern, EnumerationOptions enumerationOptions)
=> EnumerableHelpers.ToArray(InternalEnumeratePaths(path, searchPattern, SearchTarget.Files, enumerationOptions), out _);
=> new List<string>(InternalEnumeratePaths(path, searchPattern, SearchTarget.Files, enumerationOptions)).ToArray();

public static string[] GetDirectories(string path) => GetDirectories(path, "*", enumerationOptions: EnumerationOptions.Compatible);

Expand All @@ -153,7 +153,7 @@ public static string[] GetDirectories(string path, string searchPattern, SearchO
=> GetDirectories(path, searchPattern, EnumerationOptions.FromSearchOption(searchOption));

public static string[] GetDirectories(string path, string searchPattern, EnumerationOptions enumerationOptions)
=> EnumerableHelpers.ToArray(InternalEnumeratePaths(path, searchPattern, SearchTarget.Directories, enumerationOptions), out _);
=> new List<string>(InternalEnumeratePaths(path, searchPattern, SearchTarget.Directories, enumerationOptions)).ToArray();

public static string[] GetFileSystemEntries(string path) => GetFileSystemEntries(path, "*", enumerationOptions: EnumerationOptions.Compatible);

Expand All @@ -163,7 +163,7 @@ public static string[] GetFileSystemEntries(string path, string searchPattern, S
=> GetFileSystemEntries(path, searchPattern, EnumerationOptions.FromSearchOption(searchOption));

public static string[] GetFileSystemEntries(string path, string searchPattern, EnumerationOptions enumerationOptions)
=> EnumerableHelpers.ToArray(InternalEnumeratePaths(path, searchPattern, SearchTarget.Both, enumerationOptions), out _);
=> new List<string>(InternalEnumeratePaths(path, searchPattern, SearchTarget.Both, enumerationOptions)).ToArray();

internal static IEnumerable<string> InternalEnumeratePaths(
string path,
Expand Down
6 changes: 3 additions & 3 deletions src/libraries/System.Private.CoreLib/src/System/IO/DirectoryInfo.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,7 @@ public FileInfo[] GetFiles(string searchPattern, SearchOption searchOption)
=> GetFiles(searchPattern, EnumerationOptions.FromSearchOption(searchOption));

public FileInfo[] GetFiles(string searchPattern, EnumerationOptions enumerationOptions)
=> EnumerableHelpers.ToArray((IEnumerable<FileInfo>)InternalEnumerateInfos(FullPath, searchPattern, SearchTarget.Files, enumerationOptions), out _);
=> new List<FileInfo>((IEnumerable<FileInfo>)InternalEnumerateInfos(FullPath, searchPattern, SearchTarget.Files, enumerationOptions)).ToArray();

// Returns an array of strongly typed FileSystemInfo entries which will contain a listing
// of all the files and directories.
Expand All @@ -121,7 +121,7 @@ public FileSystemInfo[] GetFileSystemInfos(string searchPattern, SearchOption se
=> GetFileSystemInfos(searchPattern, EnumerationOptions.FromSearchOption(searchOption));

public FileSystemInfo[] GetFileSystemInfos(string searchPattern, EnumerationOptions enumerationOptions)
=> EnumerableHelpers.ToArray(InternalEnumerateInfos(FullPath, searchPattern, SearchTarget.Both, enumerationOptions), out _);
=> new List<FileSystemInfo>(InternalEnumerateInfos(FullPath, searchPattern, SearchTarget.Both, enumerationOptions)).ToArray();

// Returns an array of Directories in the current directory.
public DirectoryInfo[] GetDirectories() => GetDirectories("*", enumerationOptions: EnumerationOptions.Compatible);
Expand All @@ -134,7 +134,7 @@ public DirectoryInfo[] GetDirectories(string searchPattern, SearchOption searchO
=> GetDirectories(searchPattern, EnumerationOptions.FromSearchOption(searchOption));

public DirectoryInfo[] GetDirectories(string searchPattern, EnumerationOptions enumerationOptions)
=> EnumerableHelpers.ToArray((IEnumerable<DirectoryInfo>)InternalEnumerateInfos(FullPath, searchPattern, SearchTarget.Directories, enumerationOptions), out _);
=> new List<DirectoryInfo>((IEnumerable<DirectoryInfo>)InternalEnumerateInfos(FullPath, searchPattern, SearchTarget.Directories, enumerationOptions)).ToArray();

public IEnumerable<DirectoryInfo> EnumerateDirectories()
=> EnumerateDirectories("*", enumerationOptions: EnumerationOptions.Compatible);
Expand Down