Skip to content

Strip libmonosgen linked library #53240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
directhex merged 16 commits into from
Jun 8, 2021
Merged

Strip libmonosgen linked library #53240

Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
1389a4b
Strip libmonosgen linked library
May 25, 2021
61c41af
Don't strip JIT when building cross compilers only
May 25, 2021
16e9029
Unlike MacOS, Linux needs per-OS cross-compile versions of objcopy
May 25, 2021
4f59533
Try dealing with Android's objcopy not in $PATH
May 25, 2021
62e2c8b
Add a fallback, and deal with odd ABI name on armhf vs android arm
May 25, 2021
f5e401c
Implement test for objcopy command
May 26, 2021
960e6ea
Drive ExitCode better
May 26, 2021
3700f34
ContinueOnError
May 26, 2021
a57d216
Don't fail Exec task on non-zero exit code
directhex May 26, 2021
5b5751e
Actually copy debug to bin/, so it gets into .symbols.nupkg
directhex May 26, 2021
8fee408
Fix typo
directhex May 26, 2021
25410a1
Merge remote-tracking branch 'origin/main' into strip-mono-correctly
May 27, 2021
535d15e
Fix indentation
May 27, 2021
c21328c
Merge remote-tracking branch 'origin/main' into strip-mono-correctly
Jun 3, 2021
b876424
Merge remote-tracking branch 'origin/main' into strip-mono-correctly
Jun 7, 2021
b6bd810
Fix component stripping maybe
Jun 8, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add a fallback, and deal with odd ABI name on armhf vs android arm
  • Loading branch information
Jo Shields committed May 25, 2021
commit 62e2c8b11ae7c7a83d4ab5d530604def04ea09f1
5 changes: 4 additions & 1 deletion src/mono/mono.proj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -484,12 +484,15 @@
<_MonoRuntimeFilePath>$(MonoObjDir)out\lib\$(MonoFileName)</_MonoRuntimeFilePath>
<_LinuxAbi Condition="'$(TargetsAndroid)' != 'true'">gnu</_LinuxAbi>
<_LinuxAbi Condition="'$(TargetsAndroid)' == 'true'">android</_LinuxAbi>
<_LinuxFloatAbi Condition="'$(TargetsAndroid)' != 'true'">hf</_LinuxFloatAbi>
<_Objcopy>objcopy</_Objcopy>
<_Objcopy Condition="'$(Platform)' == 'arm'">arm-linux-$(_LinuxAbi)eabihf-$(_Objcopy)</_Objcopy>
<_Objcopy Condition="'$(Platform)' == 'arm'">arm-linux-$(_LinuxAbi)eabi$(_LinuxFloatAbi)-$(_Objcopy)</_Objcopy>
<_Objcopy Condition="'$(Platform)' == 'arm64'">aarch64-linux-$(_LinuxAbi)-$(_Objcopy)</_Objcopy>
<_Objcopy Condition="'$(Platform)' == 'x64'">x86_64-linux-$(_LinuxAbi)-$(_Objcopy)</_Objcopy>
<_Objcopy Condition="'$(Platform)' == 'x86'">i686-linux-$(_LinuxAbi)-$(_Objcopy)</_Objcopy>
<_Objcopy Condition="'$(TargetsAndroid)' == 'true'">$(ANDROID_NDK_ROOT)/toolchains/llvm/prebuilt/$(MonoToolchainPrebuiltOS)/bin/$(_Objcopy)</_Objcopy>
<!-- If all else fails in finding a valid objcopy, fall back to no-prefix from $PATH (used fo x64 on CentOS) -->
<_Objcopy Condition="!Exists('$(_Objcopy)')">objcopy</_Objcopy>
</PropertyGroup>
<Message Condition="'$(BuildMonoAOTCrossCompilerOnly)' != 'true' and ($([MSBuild]::IsOSPlatform('OSX')) or $([MSBuild]::IsOSPlatform('Linux')))" Text="Stripping debug symbols from $(_MonoRuntimeFilePath)" Importance="High"/>
<Exec Condition="'$(BuildMonoAOTCrossCompilerOnly)' != 'true' and $([MSBuild]::IsOSPlatform('OSX'))" Command="dsymutil --flat --minimize $(_MonoRuntimeFilePath)" IgnoreStandardErrorWarningFormat="true" WorkingDirectory="$(MonoObjDir)"/>
Expand Down