Skip to content

Ship a .framework version of Mono #53370

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
directhex merged 24 commits into from
Jul 8, 2021
Merged

Ship a .framework version of Mono #53370

Changes from 1 commit
Commits
Show all changes
24 commits
Select commit Hold shift + click to select a range
3d876f7
WIP
akoeplinger May 17, 2021
ada980d
Merge remote-tracking branch 'origin/main' into ios-xcframework
May 27, 2021
82555d5
Copy mono-framework.framework to same build dir as monosgen
May 27, 2021
4879ec7
Copy .frameworks to bin/
May 27, 2021
9e3bc17
Ship .framework in nupkg
May 27, 2021
ff168f9
Merge remote-tracking branch 'origin/main' into ios-xcframework
Jun 3, 2021
f97e186
Rename mono-framework to Mono
Jun 3, 2021
0ee1330
Merge remote-tracking branch 'origin/main' into ios-xcframework
Jun 29, 2021
7d8d578
Fix framework build on non-catalyst
Jun 29, 2021
e97ec4c
Build stubby (release) and static-component (release) .frameworks
Jun 30, 2021
f16eabb
Merge remote-tracking branch 'origin/main' into ios-xcframework
Jun 30, 2021
75ea8d1
Strip frameworks
Jun 30, 2021
9bd0b0e
What if we flatten to iOS-style unversioned frameworks on non-iOS?
Jul 1, 2021
4ee0938
Fix stripping-dwarf-files bug
Jul 2, 2021
45f4e2b
Merge remote-tracking branch 'origin/main' into ios-xcframework
Jul 2, 2021
3315ef6
Merge branch 'ios-xcframework' of github.com:directhex/runtime into i…
Jul 2, 2021
8f544ab
Bundle dylibs for components on dynamic component platforms
Jul 2, 2021
db386ee
Only build .frameworks if explicitly turned on; turn on in relevant C…
Jul 6, 2021
aa31a96
Merge remote-tracking branch 'origin/main' into ios-xcframework
Jul 6, 2021
62ab8ae
Typo
Jul 6, 2021
2837fcb
Fix casing (from Mitch)
Jul 7, 2021
65e00a7
Add explanation of whitespace fiddling to bypass cmake list limitations
Jul 7, 2021
29e9413
Release and debug were reversed (debug should get full objects, not s…
Jul 7, 2021
bd8272e
Merge remote-tracking branch 'origin/main' into ios-xcframework
Jul 8, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add explanation of whitespace fiddling to bypass cmake list limitations
  • Loading branch information
Jo Shields committed Jul 7, 2021
commit 65e00a7b620e05c31d57a36f925dabe6b74fbdb0
5 changes: 5 additions & 0 deletions src/mono/mono/mini/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -384,6 +384,11 @@ if(NOT DISABLE_SHARED_LIBS)

if(BUILD_DARWIN_FRAMEWORKS)
if(TARGET_DARWIN)
Copy link
Member

@lambdageek lambdageek Jul 7, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should be TARGET_DARWIN AND STATIC_COMPONENTS.
I think this version of the code is only right if the components are static archives, right?

Copy link
Contributor Author

@directhex directhex Jul 7, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So we should never build a .framework in the case of .dylib components? Didn't you say iOS Simulator should ship dylibs & build against stubs in #53370 (comment) ?

Copy link
Member

@lambdageek lambdageek Jul 7, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I meant to me this looks like the code only supports the static components case. I assumed a dynamic components version will be added in a follow-up PR. Maybe I misunderstood what's happening here.

# In cmake, you cannot have list entries which contain a space or semicolon - those are considered
# record separators (i.e. a list of list(APPEND foo "a" "b;c" "d e") is a five entry list of values
# a, b, c, d and e.
# So, in order to treat the components lists as single list entries, swap out the ; character
# for a temporary replacement character, allowing the full lists to be treated as single entries
string(REPLACE ";" "*" mono-components-objects-nowhitespace "${mono-components-objects}")
string(REPLACE ";" "*" mono-components-stub-objects-nowhitespace "${mono-components-stub-objects}")
list(APPEND FrameworkConfig Mono.release Mono.debug)
Expand Down