Skip to content

Fix: Incorrect order of checks for TypeBuilder GetConstructor and GetField method #53645

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
eerhardt merged 16 commits into from
Nov 2, 2021
Merged

Fix: Incorrect order of checks for TypeBuilder GetConstructor and GetField method #53645

Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
d115433
Reorder checks for TypeBuilder.GetConstructor()
BartoszKlonowski May 31, 2021
22cf90a
Reorder checks for TypeBuilder.GetField()
BartoszKlonowski May 31, 2021
f2efe72
Adjust unit test to reordered TypeBuilder checks
BartoszKlonowski Jun 3, 2021
4940fc1
Use 'not' keyword for pattern matching
BartoszKlonowski Jun 14, 2021
3472615
Apply the same Type checks for Mono
BartoszKlonowski Jun 14, 2021
fd50ec9
Check whether a declaring type isn't type's generic definition
BartoszKlonowski Jul 13, 2021
6fcfbf5
Make generic type if contains generic parameters
BartoszKlonowski Jul 14, 2021
f039dc9
Suppres UnrecognizedReflectionPattern for GetField and GetConstructor
BartoszKlonowski Jul 14, 2021
863b984
Move GetMethodType validation method at original order
BartoszKlonowski Jul 26, 2021
f806283
Test GetConstructor against throwing an exception
BartoszKlonowski Jul 26, 2021
70f45eb
Fix: copy-paste error 'type' -> 'constructor'
BartoszKlonowski Jul 26, 2021
b2c2b4a
Align Mono and CoreCLR with nameof for GetConstructor
BartoszKlonowski Jul 27, 2021
98036aa
Use type for argument exception and test against type parameter
BartoszKlonowski Jul 27, 2021
474a10b
Merge remote-tracking branch 'upstream/main' into fix-typebuilder-che…
eerhardt Oct 4, 2021
23795a0
Get tests passing on both coreclr and mono.
eerhardt Oct 6, 2021
f7ed1ac
Fix mono exception messages to use SR resources.
eerhardt Nov 2, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Suppres UnrecognizedReflectionPattern for GetField and GetConstructor
  • Loading branch information
@BartoszKlonowski
BartoszKlonowski committed Jul 14, 2021
commit f039dc9a4f9eb2a0a706f19d3efa66de6a2e20f7
4 changes: 4 additions & 0 deletions src/mono/System.Private.CoreLib/src/System/Reflection/Emit/TypeBuilder.Mono.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1858,6 +1858,8 @@ private static bool IsValidGetMethodType(Type type)

[UnconditionalSuppressMessage("ReflectionAnalysis", "IL2070:UnrecognizedReflectionPattern",
Justification = "Linker thinks Type.GetConstructor(ConstructorInfo) is one of the public APIs because it doesn't analyze method signatures. We already have ConstructorInfo.")]
[UnconditionalSuppressMessage("ReflectionAnalysis", "IL2055:UnrecognizedReflectionPattern",
Justification = "Type.MakeGenericType is used to create a typical instantiation")]
public static ConstructorInfo GetConstructor(Type type, ConstructorInfo constructor)
{
if (!IsValidGetMethodType(type))
Expand Down Expand Up @@ -1914,6 +1916,8 @@ public static MethodInfo GetMethod(Type type, MethodInfo method)
return res;
}

[UnconditionalSuppressMessage("ReflectionAnalysis", "IL2055:UnrecognizedReflectionPattern",
Justification = "Type.MakeGenericType is used to create a typical instantiation")]
public static FieldInfo GetField(Type type, FieldInfo field)
{
if (!IsValidGetMethodType(type))
Expand Down