Skip to content

Implement SinPi, CosPi and TanPi and inverses #53675

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
huoyaoyuan wants to merge 15 commits into from
Closed

Implement SinPi, CosPi and TanPi and inverses #53675

Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
f1bcae0
SinPi
huoyaoyuan Jun 3, 2021
dd97080
CosPi
huoyaoyuan Jun 3, 2021
8004559
TanPi
huoyaoyuan Jun 3, 2021
4e9532f
Test IEEE compliance of +0 and -0
huoyaoyuan Jun 4, 2021
d2c82a4
Rewrite SinPi and CosPi
huoyaoyuan Jun 4, 2021
9d2576a
Add real implementation for TanPi
huoyaoyuan Jun 4, 2021
792825f
Add correctness test
huoyaoyuan Jun 4, 2021
ced1e7e
Add AsinPi, AcosPi, AtanPi and Atan2Pi
huoyaoyuan Jun 4, 2021
e702e36
Use the term half-revolution to match IEEE spec
huoyaoyuan Jun 4, 2021
1a43b7a
Test AsinPi, AcosPi, AtanPi and Atan2Pi
huoyaoyuan Jun 4, 2021
a81b6a2
Convert Atan2Pi test to theory to observe failures
huoyaoyuan Jun 5, 2021
63ab183
Special case AcosPi and AtanPi
huoyaoyuan Jun 5, 2021
7b74167
Special cases for Atan2Pi
huoyaoyuan Jun 5, 2021
4b809ba
Special case SinPi and change Atan2Pi
huoyaoyuan Jun 5, 2021
24a4444
Fix unwanted indent change and comment
huoyaoyuan Jun 5, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Convert Atan2Pi test to theory to observe failures
  • Loading branch information
@huoyaoyuan
huoyaoyuan committed Jun 5, 2021
commit a81b6a2b227e4c772303af006ddc49e8bd4ca8e2
90 changes: 46 additions & 44 deletions src/libraries/System.Runtime.Extensions/tests/System/Math.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3361,50 +3361,52 @@ public static void AtanPi_Float_Precision()
AssertEqual(-0.5f, MathF.AtanPi(float.NegativeInfinity), 0.0f);
}

[Fact]
public static void Atan2Pi_Double_Precision()
{
AssertEqual( 1.00, Math.Atan2Pi( 0.0, -0.0), 0.0);
AssertEqual(-1.00, Math.Atan2Pi(-0.0, -0.0), 0.0);
AssertEqual( 1.00, Math.Atan2Pi( 0.0, -1.0), 0.0);
AssertEqual(-1.00, Math.Atan2Pi(-0.0, -1.0), 0.0);
AssertEqual(-0.50, Math.Atan2Pi(-1.0, 0.0), 0.0);
AssertEqual(-0.50, Math.Atan2Pi(-1.0, -0.0), 0.0);
AssertEqual( 0.50, Math.Atan2Pi( 1.0, 0.0), 0.0);
AssertEqual( 0.50, Math.Atan2Pi( 1.0, -0.0), 0.0);
AssertEqual( 1.00, Math.Atan2Pi( 1.0, double.NegativeInfinity), 0.0);
AssertEqual(-1.00, Math.Atan2Pi(-1.0, double.NegativeInfinity), 0.0);
AssertEqual( 0.50, Math.Atan2Pi(double.PositiveInfinity, 1.0), 0.0);
AssertEqual( 0.50, Math.Atan2Pi(double.PositiveInfinity, -1.0), 0.0);
AssertEqual(-0.50, Math.Atan2Pi(double.NegativeInfinity, 1.0), 0.0);
AssertEqual(-0.50, Math.Atan2Pi(double.NegativeInfinity, -1.0), 0.0);
AssertEqual( 0.75, Math.Atan2Pi(double.PositiveInfinity, double.NegativeInfinity), 0.0);
AssertEqual(-0.75, Math.Atan2Pi(double.NegativeInfinity, double.NegativeInfinity), 0.0);
AssertEqual( 0.25, Math.Atan2Pi(double.PositiveInfinity, double.PositiveInfinity), 0.0);
AssertEqual(-0.25, Math.Atan2Pi(double.NegativeInfinity, double.PositiveInfinity), 0.0);
}

[Fact]
public static void Atan2Pi_Float_Precision()
{
AssertEqual( 1.00f, MathF.Atan2Pi( 0.0f, -0.0f), 0.0f);
AssertEqual(-1.00f, MathF.Atan2Pi(-0.0f, -0.0f), 0.0f);
AssertEqual( 1.00f, MathF.Atan2Pi( 0.0f, -1.0f), 0.0f);
AssertEqual(-1.00f, MathF.Atan2Pi(-0.0f, -1.0f), 0.0f);
AssertEqual(-0.50f, MathF.Atan2Pi(-1.0f, 0.0f), 0.0f);
AssertEqual(-0.50f, MathF.Atan2Pi(-1.0f, -0.0f), 0.0f);
AssertEqual( 0.50f, MathF.Atan2Pi( 1.0f, 0.0f), 0.0f);
AssertEqual( 0.50f, MathF.Atan2Pi( 1.0f, -0.0f), 0.0f);
AssertEqual( 1.00f, MathF.Atan2Pi( 1.0f, float.NegativeInfinity), 0.0f);
AssertEqual(-1.00f, MathF.Atan2Pi(-1.0f, float.NegativeInfinity), 0.0f);
AssertEqual( 0.50f, MathF.Atan2Pi(float.PositiveInfinity, 1.0f), 0.0f);
AssertEqual( 0.50f, MathF.Atan2Pi(float.PositiveInfinity, -1.0f), 0.0f);
AssertEqual(-0.50f, MathF.Atan2Pi(float.NegativeInfinity, 1.0f), 0.0f);
AssertEqual(-0.50f, MathF.Atan2Pi(float.NegativeInfinity, -1.0f), 0.0f);
AssertEqual( 0.75f, MathF.Atan2Pi(float.PositiveInfinity, float.NegativeInfinity), 0.0f);
AssertEqual(-0.75f, MathF.Atan2Pi(float.NegativeInfinity, float.NegativeInfinity), 0.0f);
AssertEqual( 0.25f, MathF.Atan2Pi(float.PositiveInfinity, float.PositiveInfinity), 0.0f);
AssertEqual(-0.25f, MathF.Atan2Pi(float.NegativeInfinity, float.PositiveInfinity), 0.0f);
[Theory]
[InlineData( 0.0, -0.0, 1.0)]
[InlineData(-0.0, -0.0, -1.0)]
[InlineData( 0.0, -1.0, 1.0)]
[InlineData(-0.0, -1.0, -1.0)]
[InlineData(-1.0, 0.0, -0.5)]
[InlineData(-1.0, -0.0, -0.5)]
[InlineData( 1.0, 0.0, 0.5)]
[InlineData( 1.0, -0.0, 0.5)]
[InlineData( 1.0, double.NegativeInfinity, 1.0)]
[InlineData(-1.0, double.NegativeInfinity, -1.0)]
[InlineData(double.PositiveInfinity, 1.0, 0.5)]
[InlineData(double.PositiveInfinity, -1.0, 0.5)]
[InlineData(double.NegativeInfinity, 1.0, -0.5)]
[InlineData(double.NegativeInfinity, -1.0, -0.5)]
[InlineData(double.PositiveInfinity, double.NegativeInfinity, 0.75)]
[InlineData(double.NegativeInfinity, double.NegativeInfinity, -0.75)]
[InlineData(double.PositiveInfinity, double.PositiveInfinity, 0.25)]
[InlineData(double.NegativeInfinity, double.PositiveInfinity, -0.25)]
public static void Atan2Pi_Double_Precision(double y, double x, double expected)
{
AssertEqual(expected, Math.Atan2Pi(y, x), 0.0);
}

[Theory]
[InlineData( 0.0f, -0.0f, 1.0f)]
[InlineData(-0.0f, -0.0f, -1.0f)]
[InlineData( 0.0f, -1.0f, 1.0f)]
[InlineData(-0.0f, -1.0f, -1.0f)]
[InlineData(-1.0f, 0.0f, -0.5f)]
[InlineData(-1.0f, -0.0f, -0.5f)]
[InlineData( 1.0f, 0.0f, 0.5f)]
[InlineData( 1.0f, -0.0f, 0.5f)]
[InlineData( 1.0f, float.NegativeInfinity, 1.0f)]
[InlineData(-1.0f, float.NegativeInfinity, -1.0f)]
[InlineData(float.PositiveInfinity, 1.0f, 0.5f)]
[InlineData(float.PositiveInfinity, -1.0f, 0.5f)]
[InlineData(float.NegativeInfinity, 1.0f, -0.5f)]
[InlineData(float.NegativeInfinity, -1.0f, -0.5f)]
[InlineData(float.PositiveInfinity, float.NegativeInfinity, 0.75f)]
[InlineData(float.NegativeInfinity, float.NegativeInfinity, -0.75f)]
[InlineData(float.PositiveInfinity, float.PositiveInfinity, 0.25f)]
[InlineData(float.NegativeInfinity, float.PositiveInfinity, -0.25f)]
public static void Atan2Pi_Float_Precision(float y, float x, float expected)
{
AssertEqual(expected, MathF.Atan2Pi(y, x), 0.0f);
}
}
}