Skip to content

Move the "do not zero-extend setcc" optimization to lower #53778

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kunalspathak merged 4 commits into from
Jul 13, 2021
+33 −44
Merged

Move the "do not zero-extend setcc" optimization to lower #53778

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e7e4aac
Strongly type StoreInd lowering
SingleAccretion Jun 6, 2021
3564285
Improve clarity of code through the use of helpers
SingleAccretion Jun 6, 2021
8014879
Move the "do not zero-extend setcc" to lowering
SingleAccretion Jun 6, 2021
0d79c9a
Delete now unnecessary copying of the relop type
SingleAccretion Jun 13, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Delete now unnecessary copying of the relop type
  • Loading branch information
@SingleAccretion
SingleAccretion committed Jun 13, 2021
commit 0d79c9a514c7530a493b65b742b9e504bbc9e6b0
3 changes: 0 additions & 3 deletions src/coreclr/jit/morph.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13637,9 +13637,6 @@ GenTree* Compiler::fgMorphSmpOp(GenTree* tree, MorphAddrContext* mac)
gtReverseCond(op1);
}

/* Propagate gtType of tree into op1 in case it is TYP_BYTE for setcc optimization */
op1->gtType = tree->gtType;

noway_assert((op1->gtFlags & GTF_RELOP_JMP_USED) == 0);
op1->gtFlags |= tree->gtFlags & (GTF_RELOP_JMP_USED | GTF_RELOP_QMARK | GTF_DONT_CSE);

Expand Down