Skip to content

rework SocketsHttpHandler request queue handling for HTTP/1.1 and HTTP/2 #53851

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
geoffkizer merged 9 commits into from
Jul 15, 2021
Merged

rework SocketsHttpHandler request queue handling for HTTP/1.1 and HTTP/2 #53851

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
d6d69d0
rework SocketsHttpHandler request queue handling for HTTP/1.1 and HTTP/2
Apr 13, 2021
6087427
clarify shutdown state
Jun 23, 2021
5ff6661
review feedback and cleanup
Jun 23, 2021
65e8e7f
fix scavenge issue and add some asserts
Jun 24, 2021
e5af1b7
fixup from merge
Jul 13, 2021
05bae0f
fix merge issues
Jul 13, 2021
a9c3ff5
test fixes
Jul 13, 2021
fd8154b
test fix
Jul 14, 2021
df30169
fix assert for finalization
Jul 14, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
test fix
  • Loading branch information
Geoffrey Kizer committed Jul 14, 2021
commit fd8154b649af34a63ed32bb850cac0a65c890f01
10 changes: 5 additions & 5 deletions src/libraries/System.Net.Http/tests/FunctionalTests/HttpClientHandlerTest.Http2.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -244,10 +244,10 @@ public async Task Http2_ServerSendsValidSettingsValues_Success()
}

[ConditionalTheory(nameof(SupportsAlpn))]
[InlineData(SettingId.MaxFrameSize, 16383, ProtocolErrors.PROTOCOL_ERROR)]
[InlineData(SettingId.MaxFrameSize, 162777216, ProtocolErrors.PROTOCOL_ERROR)]
[InlineData(SettingId.InitialWindowSize, 0x80000000, ProtocolErrors.FLOW_CONTROL_ERROR)]
public async Task Http2_ServerSendsInvalidSettingsValue_Error(SettingId settingId, uint value, ProtocolErrors expectedError)
[InlineData(SettingId.MaxFrameSize, 16383)]
[InlineData(SettingId.MaxFrameSize, 162777216)]
[InlineData(SettingId.InitialWindowSize, 0x80000000)]
public async Task Http2_ServerSendsInvalidSettingsValue_Error(SettingId settingId, uint value)
{
using (Http2LoopbackServer server = Http2LoopbackServer.CreateServer())
using (HttpClient client = CreateHttpClient())
Expand All @@ -257,7 +257,7 @@ public async Task Http2_ServerSendsInvalidSettingsValue_Error(SettingId settingI
// Send invalid initial SETTINGS value
Http2LoopbackConnection connection = await server.EstablishConnectionAsync(new SettingsEntry { SettingId = settingId, Value = value });

await AssertProtocolErrorAsync(sendTask, expectedError);
await Assert.ThrowsAsync<HttpRequestException>(() => sendTask);

connection.Dispose();
}
Expand Down