Skip to content

Change PathInternal.IsCaseSensitive to a constant #54340

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lambdageek merged 13 commits into from
Jun 23, 2021
Merged

Change PathInternal.IsCaseSensitive to a constant #54340

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
c604c47
Return constants in PathInternal.GetIsCaseSensitive() on mobile platf…
lambdageek Jun 18, 2021
7b8ba3e
Put OperatingSystem probing under a NET6_0_OR_GREATER define
lambdageek Jun 18, 2021
6e7d107
Apply suggested changes
lambdageek Jun 21, 2021
4ac6f7d
Implement Path.IsCaseSensitive as PathInternal.IsCaseSensitive
lambdageek Jun 21, 2021
731c90d
Add test for PathInternal.IsCaseSensitive
lambdageek Jun 21, 2021
4476863
Drop PathInternal.s_isCaseSensitive cache field
lambdageek Jun 21, 2021
40ef8ec
Delete Path.IsCaseSensitive and Path.StringComparison
lambdageek Jun 21, 2021
ad2e8f2
Remove catch clause from GetIsCaseSensitiveByProbing
lambdageek Jun 21, 2021
84e7779
fixup Net5CompatTests
lambdageek Jun 21, 2021
e1098a1
Mark new test [OuterLoop]
lambdageek Jun 21, 2021
591af35
Apply suggestions from code review
adamsitnik Jun 22, 2021
b971e4b
fix formatting
adamsitnik Jun 22, 2021
df04df4
Apply suggestions
lambdageek Jun 22, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Remove catch clause from GetIsCaseSensitiveByProbing
  • Loading branch information
@lambdageek
lambdageek committed Jun 21, 2021
commit ad2e8f2eb68046e748920d8d6961c6ff5fd4ee43
21 changes: 6 additions & 15 deletions src/libraries/System.IO.FileSystem/tests/FileSystemTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,21 +139,12 @@ protected void ReadOnly_FileSystemHelper(Action<string> testAction, string subDi
/// </remarks>
protected static bool GetIsCaseSensitiveByProbing(string probingDirectory)
{
try
{
string pathWithUpperCase = Path.Combine(probingDirectory, "CASESENSITIVETEST" + Guid.NewGuid().ToString("N"));
using (new FileStream(pathWithUpperCase, FileMode.CreateNew, FileAccess.ReadWrite, FileShare.None, 0x1000, FileOptions.DeleteOnClose))
{
string lowerCased = pathWithUpperCase.ToLowerInvariant();
return !File.Exists(lowerCased);
}
}
catch
{
// In case something goes wrong (e.g. temp pointing to a privilieged directory), we don't
// want to fail just because of a casing test, so we assume case-insensitive-but-preserving.
return false;
}
string pathWithUpperCase = Path.Combine(probingDirectory, "CASESENSITIVETEST" + Guid.NewGuid().ToString("N"));
using (new FileStream(pathWithUpperCase, FileMode.CreateNew, FileAccess.ReadWrite, FileShare.None, 0x1000, FileOptions.DeleteOnClose))
{
string lowerCased = pathWithUpperCase.ToLowerInvariant();
return !File.Exists(lowerCased);
}
}
}
}