Skip to content

Only include Microsoft.NET.Runtime.RuntimeConfigParser.Task on mobile #54361

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
lewing merged 2 commits into from
Jun 18, 2021
Merged

Only include Microsoft.NET.Runtime.RuntimeConfigParser.Task on mobile #54361

lewing merged 2 commits into from
Jun 18, 2021

Conversation

@lewing
Copy link
Member

@lewing lewing commented Jun 17, 2021

@lewing lewing requested a review from steveisok June 17, 2021 20:04
@lewing lewing requested a review from marek-safar as a code owner June 17, 2021 20:04
@ghost
Copy link

ghost commented Jun 17, 2021

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

@lewing lewing requested a review from dsplaisted June 17, 2021 20:05
@ghost
Copy link

ghost commented Jun 17, 2021

Tagging subscribers to this area: @directhex
See info in area-owners.md if you want to be subscribed.

Issue Details

dotnet/installer#10856 (comment)

Author: lewing
Assignees: -
Labels:

area-Infrastructure-mono
Milestone: -

@lewing
Copy link
Member Author

lewing commented Jun 17, 2021

@steveisok does android need this all the time or can it be skipped in some cases?

@steveisok
Copy link
Member

steveisok commented Jun 17, 2021

@steveisok does android need this all the time or can it be skipped in some cases?

I believe so, but @jonathanpeppers can better answer that.

@jonathanpeppers
Copy link
Member

jonathanpeppers commented Jun 17, 2021

Yes, Android & Apple platforms use the <RuntimeConfigParser/> MSBuild task now by default.

@lewing
Copy link
Member Author

lewing commented Jun 17, 2021

/backport to release/6.0-preview6

@github-actions
Copy link
Contributor

github-actions bot commented Jun 17, 2021

Started backporting to release/6.0-preview6: https://github.com/dotnet/runtime/actions/runs/947852045

@github-actions github-actions bot mentioned this pull request Jun 17, 2021
Merged
@lewing
Copy link
Member Author

lewing commented Jun 18, 2021

The maccatalyst failure isn't relevant because the workload isn't actually used in any part of the runtime build that is being tested on that lane.

@lewing lewing merged commit 98be10a into dotnet:main Jun 18, 2021
@lewing lewing deleted the mobile-runtime-config branch June 18, 2021 00:25
steveisok pushed a commit to steveisok/runtime that referenced this pull request Jun 22, 2021
Import the correct MacCatalyst workload pack
77fc653 
In dotnet#54361 there was an incorrect import of the maccatalyst aot workload pack.  This fix corrects the problem.

Fixes dotnet#54494
@steveisok steveisok mentioned this pull request Jun 22, 2021
Merged
github-actions bot pushed a commit that referenced this pull request Jun 22, 2021
Import the correct MacCatalyst workload pack
3ca825f 
In #54361 there was an incorrect import of the maccatalyst aot workload pack.  This fix corrects the problem.

Fixes #54494
steveisok added a commit that referenced this pull request Jun 22, 2021
@steveisok
Import the correct MacCatalyst workload pack (#54558)
98db254 
In #54361 there was an incorrect import of the maccatalyst aot workload pack.  This fix corrects the problem.

Fixes #54494
steveisok pushed a commit that referenced this pull request Jun 24, 2021
@github-actions
Import the correct MacCatalyst workload pack (#54561)
b1e9def 
In #54361 there was an incorrect import of the maccatalyst aot workload pack.  This fix corrects the problem.

Fixes #54494
@ghost ghost locked as resolved and limited conversation to collaborators Jul 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@dsplaisted dsplaisted dsplaisted approved these changes

@steveisok steveisok Awaiting requested review from steveisok

@marek-safar marek-safar Awaiting requested review from marek-safar

Assignees

No one assigned

Labels

area-Infrastructure-mono

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@lewing @steveisok @jonathanpeppers @dsplaisted