Skip to content

Enable property visibility tests in source-gen mode #54526

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
layomia merged 5 commits into from
Jul 13, 2021
Merged

Enable property visibility tests in source-gen mode #54526

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
4f2f801
Enable property visibility tests in source-gen mode
layomia Jun 20, 2021
7712b6d
Address feedback
layomia Jul 12, 2021
5bec803
Fix S.N.H.Json tests
layomia Jul 12, 2021
653bfd3
Fix S.T.J tests
layomia Jul 12, 2021
6c68152
Fix S.N.H.J tests ii
layomia Jul 12, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix S.N.H.Json tests
  • Loading branch information
@layomia
layomia committed Jul 12, 2021
commit 5bec8033762a4c2532cd3e05071fe73b449d6894
12 changes: 12 additions & 0 deletions src/libraries/System.Net.Http.Json/tests/FunctionalTests/JsonContext/Person.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,51 +47,63 @@ private static JsonPropertyInfo[] PersonPropInitFunc(JsonSerializerContext conte
properties[0] = JsonMetadataServices.CreatePropertyInfo(
options,
isProperty: true,
isPublic: false,
isVirtual: false,
declaringType: typeof(Person),
propertyTypeInfo: jsonContext.Int32,
converter: null,
getter: static (obj) => { return ((Person)obj).Age; },
setter: static (obj, value) => { ((Person)obj).Age = value; },
ignoreCondition: default,
hasJsonInclude: false,
numberHandling: default,
propertyName: nameof(Tests.Person.Age),
jsonPropertyName: null);

properties[1] = JsonMetadataServices.CreatePropertyInfo(
options,
isProperty: true,
isPublic: false,
isVirtual: false,
declaringType: typeof(Person),
propertyTypeInfo: jsonContext.String,
converter: null,
getter: static (obj) => { return ((Person)obj).Name; },
setter: static (obj, value) => { ((Person)obj).Name = value; },
ignoreCondition: default,
hasJsonInclude: false,
numberHandling: default,
propertyName: nameof(Tests.Person.Name),
jsonPropertyName: null);

properties[2] = JsonMetadataServices.CreatePropertyInfo(
options,
isProperty: true,
isPublic: false,
isVirtual: false,
declaringType: typeof(Person),
propertyTypeInfo: jsonContext.Person,
converter: null,
getter: static (obj) => { return ((Person)obj).Parent; },
setter: static (obj, value) => { ((Person)obj).Parent = value; },
ignoreCondition: default,
hasJsonInclude: false,
numberHandling: default,
propertyName: nameof(Tests.Person.Parent),
jsonPropertyName: null);

properties[3] = JsonMetadataServices.CreatePropertyInfo(
options,
isProperty: true,
isPublic: false,
isVirtual: false,
declaringType: typeof(Person),
propertyTypeInfo: jsonContext.String,
converter: null,
getter: static (obj) => { return ((Person)obj).PlaceOfBirth; },
setter: static (obj, value) => { ((Person)obj).PlaceOfBirth = value; },
ignoreCondition: default,
hasJsonInclude: false,
numberHandling: default,
propertyName: nameof(Tests.Person.PlaceOfBirth),
jsonPropertyName: null);
Expand Down