Skip to content

Fix alloc-dealloc mismatches #54701

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jkoritzinsky merged 3 commits into from
Jun 28, 2021
Merged

Fix alloc-dealloc mismatches #54701

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2d51acd
Use specialized new operators to correctly allocate space with the no…
jkoritzinsky Jun 23, 2021
1e41179
Fix alloc-dealloc mismatch in ILStubResolver
jkoritzinsky Jun 23, 2021
b5313e2
Update src/coreclr/vm/ilstubresolver.cpp
jkoritzinsky Jun 24, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Update src/coreclr/vm/ilstubresolver.cpp
  • Loading branch information
@jkoritzinsky
jkoritzinsky authored Jun 24, 2021
commit b5313e2c459e7ad2b4859db184efb93b8d249fb4
1 change: 0 additions & 1 deletion src/coreclr/vm/ilstubresolver.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -345,7 +345,6 @@ ILStubResolver::AllocGeneratedIL(
{
NewArrayHolder<BYTE> pNewILCodeBuffer = new BYTE[cbCode];
NewHolder<CompileTimeState> pNewCompileTimeState = new CompileTimeState{};
Copy link
Member

@jkotas jkotas Jun 24, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For my education - does new CompileTimeState{} allocate the space without calling any constructor?

Copy link
Member Author

@jkoritzinsky jkoritzinsky Jun 24, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. It actually zero-inits, so I can remove the memset on the next line.

memset(pNewCompileTimeState, 0, sizeof(CompileTimeState));
NewArrayHolder<BYTE> pNewLocalSig = NULL;

if (0 != cbLocalSig)
Expand Down