Skip to content

Clean up some DI code #54732

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
davidfowl merged 1 commit into from
Jun 26, 2021
Merged

Clean up some DI code #54732

davidfowl merged 1 commit into from
Jun 26, 2021

Conversation

@davidfowl
Copy link
Member

@davidfowl davidfowl commented Jun 25, 2021

  • Remove empty CreateInstanceCallSite file
  • Removed ServiceScopeFactoryCallsite and used ConstantCallsite instead.
  • Added fast path if the value is already cached on the callsite.

@davidfowl
Clean up some DI code
306042b 
- Remove empty CreateInstanceCallSite file
- Removed ServiceScopeFactoryCallsite and used ConstantCallsite instead.
- Added fast path if the value is already cached on the callsite.
@davidfowl davidfowl requested a review from maryamariyan June 25, 2021 08:21
@ghost
Copy link

ghost commented Jun 25, 2021

Tagging subscribers to this area: @eerhardt, @maryamariyan
See info in area-owners.md if you want to be subscribed.

Issue Details
  • Remove empty CreateInstanceCallSite file
  • Removed ServiceScopeFactoryCallsite and used ConstantCallsite instead.
  • Added fast path if the value is already cached on the callsite.
Author: davidfowl
Assignees: -
Labels:

area-Extensions-DependencyInjection
Milestone: -

@davidfowl davidfowl requested review from eerhardt and pakrym June 25, 2021 08:21
@runfoapp runfoapp bot mentioned this pull request Jun 25, 2021
Closed
@davidfowl
Copy link
Member Author

davidfowl commented Jun 26, 2021

/azp list

@azure-pipelines
Copy link

azure-pipelines bot commented Jun 26, 2021

CI/CD Pipelines for this repository:

@davidfowl
Copy link
Member Author

davidfowl commented Jun 26, 2021

/azp run runtime

@azure-pipelines
Copy link

azure-pipelines bot commented Jun 26, 2021

Azure Pipelines successfully started running 1 pipeline(s).

@davidfowl
Copy link
Member Author

davidfowl commented Jun 26, 2021

/azp run runtime-dev-innerloop

@azure-pipelines
Copy link

azure-pipelines bot commented Jun 26, 2021

Azure Pipelines successfully started running 1 pipeline(s).

@davidfowl
Copy link
Member Author

davidfowl commented Jun 26, 2021

/azp run runtime-staging

@azure-pipelines
Copy link

azure-pipelines bot commented Jun 26, 2021

Azure Pipelines successfully started running 1 pipeline(s).

@davidfowl
Copy link
Member Author

davidfowl commented Jun 26, 2021

/azp run dotnet-linker-tests

@azure-pipelines
Copy link

azure-pipelines bot commented Jun 26, 2021

Azure Pipelines successfully started running 1 pipeline(s).

@davidfowl
Copy link
Member Author

davidfowl commented Jun 26, 2021

Test failures are unrelated. SocketsHttpHandler test timing out, mono interpreter test with System.Security.Cryptography.Xml.Tests are crashing.

@davidfowl davidfowl merged commit c7e37b1 into main Jun 26, 2021
@eerhardt eerhardt deleted the davidfowl/di-cleanup branch June 27, 2021 14:00
@kunalspathak
Copy link
Contributor

kunalspathak commented Jul 1, 2021

Perf regression in arm64: DrewScoggins/performance-2#7130

@kunalspathak
Copy link
Contributor

kunalspathak commented Jul 1, 2021

Perf improvements in arm64: DrewScoggins/performance-2#7137

@davidfowl
Copy link
Member Author

davidfowl commented Jul 6, 2021

So it both regressed and improved performance. I like it.

@kunalspathak
Copy link
Contributor

kunalspathak commented Jul 6, 2021

Are the regressions expected?

@davidfowl
Copy link
Member Author

davidfowl commented Jul 6, 2021

No, I'm not sure why it regressed.

@davidfowl
Copy link
Member Author

davidfowl commented Jul 12, 2021

My guess is that this change #55340 fixed the regression.

@kunalspathak
Copy link
Contributor

kunalspathak commented Jul 12, 2021

Looks to be the case:
image

@davidfowl
Copy link
Member Author

davidfowl commented Jul 12, 2021

Excellent

@karelz karelz mentioned this pull request Jul 28, 2021
Closed
@maryamariyan maryamariyan mentioned this pull request Aug 3, 2021
Closed
@ghost ghost locked as resolved and limited conversation to collaborators Aug 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@eerhardt eerhardt Awaiting requested review from eerhardt

2 more reviewers

@pakrym pakrym pakrym approved these changes

@maryamariyan maryamariyan maryamariyan approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

area-Extensions-DependencyInjection

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@davidfowl @kunalspathak @pakrym @maryamariyan