Remove IL2050 in System.Management #54810
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove unused functions which trigger IL2050 As per discussed in dotnet#54317
ghost
added
the
stephentoub
reviewed
Jun 28, 2021
| [DllImport(Libraries.Ole32)] | ||
| internal static extern int CoGetObjectContext([MarshalAs(UnmanagedType.LPStruct)] Guid riid, out IntPtr ppv); | ||
| [DllImport(Libraries.Ole32, PreserveSig = false)] | ||
| internal static extern IStream CreateStreamOnHGlobal(IntPtr hGlobal, bool fDeleteOnRelease); |
Member
There was a problem hiding this comment.
Took me a sec to figure out what was going on here. Thanks for fixing the swap.
Contributor
Author
There was a problem hiding this comment.
I hear you. I was in similar position before :)
Member
|
cc: @eerhardt |
eerhardt
approved these changes
Jun 28, 2021
Member
eerhardt
left a comment
eerhardt
left a comment
There was a problem hiding this comment.
This LGTM. Thanks for the fix up here.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove unused functions which trigger IL2050
As per discussed in #54317