Skip to content

Use XmlWriter.Create instead of XmlTextWriter #54949

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
stephentoub merged 6 commits into from
Jul 15, 2021
+21 −10
Merged

Use XmlWriter.Create instead of XmlTextWriter #54949

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
4487a92
Use a different XmlWriter which will check for invalid characters lik…
StephenMolloy Jun 30, 2021
12c3bae
Bring our XmlReader use into the 21st century as well.
StephenMolloy Jun 30, 2021
e3d3bf4
Update src/libraries/System.Private.Xml/src/System/Xml/Serialization/…
StephenMolloy Jul 11, 2021
2f43131
Update src/libraries/System.Private.Xml/src/System/Xml/Serialization/…
StephenMolloy Jul 11, 2021
a10731a
Update src/libraries/System.Private.Xml/src/System/Xml/Serialization/…
StephenMolloy Jul 11, 2021
0c0f2b2
Don't need to specify options that are defaults on XmlWriter.
StephenMolloy Jul 13, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update src/libraries/System.Private.Xml/src/System/Xml/Serialization/… 
…XmlSerializer.cs

Co-authored-by: Stephen Toub <[email protected]>
  • Loading branch information
@StephenMolloy @stephentoub
StephenMolloy and stephentoub authored Jul 11, 2021
commit 2f43131799aab4cf820bab352bb33d643a4de69b
3 changes: 0 additions & 3 deletions src/libraries/System.Private.Xml/src/System/Xml/Serialization/XmlSerializer.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -330,9 +330,6 @@ public void Serialize(Stream stream, object? o)
[RequiresUnreferencedCode(TrimSerializationWarning)]
public void Serialize(Stream stream, object? o, XmlSerializerNamespaces? namespaces)
{
//XmlTextWriter xmlWriter = new XmlTextWriter(stream, null);
//xmlWriter.Formatting = Formatting.Indented;
//xmlWriter.Indentation = 2;
XmlWriter xmlWriter = XmlWriter.Create(stream, new XmlWriterSettings() { CheckCharacters = true, IndentChars = " ", Indent = true });
Serialize(xmlWriter, o, namespaces);
Copy link
Member

@mconnew mconnew Jul 13, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same for this, skip setting values to the defaults.

}
Expand Down