Skip to content

Make LambdaCompiler prefer interpretation to compilation on iOS #54970

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
steveisok merged 20 commits into from
Jul 9, 2021
Merged

Make LambdaCompiler prefer interpretation to compilation on iOS #54970

Changes from 1 commit
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
f4d448c
Make LambdaCompiler prefer interpretation to compilation on iOS
MaximLipnin Jun 30, 2021
c05dfd5
Simplify the condition
MaximLipnin Jun 30, 2021
bdac243
Merge branch 'main' into prefer_interp_for_lambda_compiler_on_ios
MaximLipnin Jul 1, 2021
c6ebcfd
Extend the IsInterpreting condition to the other apple mobile platforms
MaximLipnin Jul 1, 2021
dac905e
Extract a separate functional test
MaximLipnin Jul 1, 2021
0987d1f
Set the right condition for IsInterpreting property in the test cspro…
MaximLipnin Jul 2, 2021
ae5d13d
Merge branch 'main' into prefer_interp_for_lambda_compiler_on_ios
MaximLipnin Jul 2, 2021
79e2afd
Disable a couple of tests
MaximLipnin Jul 2, 2021
4f94240
Use PlatformDetection to check that System.Linq.Expressions was compi…
MaximLipnin Jul 2, 2021
01068dd
Disable failing System.Dynamic.Runtime library tests
MaximLipnin Jul 3, 2021
21e7084
Merge branch 'main' into prefer_interp_for_lambda_compiler_on_ios
MaximLipnin Jul 3, 2021
2520971
Address issue with Microsoft.VisualBasic.CompilerServices.Tests
MaximLipnin Jul 5, 2021
bb5abac
Merge branch 'main' into prefer_interp_for_lambda_compiler_on_ios
MaximLipnin Jul 5, 2021
9fa02a6
Fix build issue
MaximLipnin Jul 5, 2021
940a10d
Merge branch 'main' into prefer_interp_for_lambda_compiler_on_ios
MaximLipnin Jul 5, 2021
a4813f9
Revert the test
MaximLipnin Jul 5, 2021
c3a3530
Update the invariant functional test for ios simulator
MaximLipnin Jul 6, 2021
ab03032
Re-enable some SLE tests on tvOS
MaximLipnin Jul 6, 2021
7c6ee4f
Merge branch 'main' into prefer_interp_for_lambda_compiler_on_ios
MaximLipnin Jul 6, 2021
038b4d5
Disable Microsoft.CSharp library test suite due to app crash in CI
MaximLipnin Jul 6, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix build issue
  • Loading branch information
@MaximLipnin
MaximLipnin committed Jul 5, 2021
commit 9fa02a6cd7d4b3b2aa0211cbd19df63f77bc79ea
18 changes: 14 additions & 4 deletions src/libraries/Microsoft.VisualBasic.Core/tests/NewLateBindingTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,11 +114,21 @@ public void LateCall_OptionalValues(string memberName, object[] arguments, Type[
Assert.Equal(expectedValue, actualValue);
}

public static IEnumerable<object[]> LateCall_OptionalValues_WithInterpretingOnly_Data()
{
// If System.Type.Missing is used for a parameter with type parameter type,
// System.Reflection.Missing is used in type inference. This matches .NET Framework behavior.

yield return CreateData("F8", new object[] { 1, 2, 3, 4, 5, 6, 7, -1 }, null);
yield return CreateData("F8", new object[] { 1, 2, 3, 4, 5, 6, 7, Type.Missing }, null);
yield return CreateData("F8", new object[] { 1, 2, 3, 4, 5, 6, Type.Missing, Type.Missing }, null);

static object[] CreateData(string memberName, object[] arguments, Type[] typeArguments) => new object[] { memberName, arguments, typeArguments };
}

[ConditionalTheory(typeof(PlatformDetection), nameof(PlatformDetection.IsLinqExpressionsBuiltWithIsInterpretingOnly))]
[InlineData("F8", new object[] { 1, 2, 3, 4, 5, 6, 7, -1 }, null, "System.Int32, 7, -1")]
[InlineData("F8", new object[] { 1, 2, 3, 4, 5, 6, 7, Type.Missing }, null, "System.Int32, 7, 8")]
[InlineData("F8", new object[] { 1, 2, 3, 4, 5, 6, Type.Missing, Type.Missing }, null, "System.Reflection.Missing, null, 8")]
public void LateCall_OptionalValues_WithInterpretingOnly(string memberName, object[] arguments, Type[] typeArguments, string expectedValue)
[MemberData(nameof(LateCall_OptionalValues_WithInterpretingOnly_Data))]
public void LateCall_OptionalValues_WithInterpretingOnly_Throws_PNSE(string memberName, object[] arguments, Type[] typeArguments)
{
Assert.Throws<PlatformNotSupportedException>(() => NewLateBinding.LateCall(
Instance: new OptionalValuesType(),
Expand Down