Skip to content

Expose nullability info #54985

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
buyaa-n merged 12 commits into from
Jul 13, 2021
Merged

Expose nullability info #54985

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
2f7d8e6
Expose nullability info from Reflection
buyaa-n Jun 2, 2021
364948a
Merge branch 'main' of https://github.com/dotnet/runtime into expose_…
buyaa-n Jun 22, 2021
d88b817
Expose nullability info from Reflection, latest updates
buyaa-n Jun 23, 2021
2c9e791
Update generic array nullability T[]
buyaa-n Jun 30, 2021
df9304c
Add doc
buyaa-n Jun 30, 2021
bbc21a6
Apply feedback
buyaa-n Jul 1, 2021
e190c91
Use GetMemberWithSameMetadataDefinitionAs instead of Module.ResolveMe…
buyaa-n Jul 2, 2021
47fdafe
Address more feedback
buyaa-n Jul 7, 2021
8fec701
Merge conflict
buyaa-n Jul 7, 2021
bfd9f1b
Temoporarily disable tests on mono
buyaa-n Jul 7, 2021
86a287d
Read only property WriteState=Unknown, disable tests on mono
buyaa-n Jul 9, 2021
4c6e667
Add RequiresUnreferencedCode attribute to warn about trimmer
buyaa-n Jul 13, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Add RequiresUnreferencedCode attribute to warn about trimmer
  • Loading branch information
@buyaa-n
buyaa-n committed Jul 13, 2021
commit 4c6e6672621d5c5184f3386aafab755ffd28e86d
4 changes: 4 additions & 0 deletions src/libraries/System.Private.CoreLib/src/System/Reflection/NullabilityInfoContext.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,7 @@ private NullabilityState GetNullableContext(MemberInfo? memberInfo)
/// <param name="parameterInfo">The parameter which nullability info gets populated</param>
/// <exception cref="ArgumentNullException">If the parameterInfo parameter is null</exception>
/// <returns><see cref="NullabilityInfo" /></returns>
[RequiresUnreferencedCode("By default nullability attributes are trimmed by the trimmer")]
public NullabilityInfo Create(ParameterInfo parameterInfo)
{
if (parameterInfo is null)
Expand Down Expand Up @@ -171,6 +172,7 @@ private void CheckNullabilityAttributes(NullabilityInfo nullability, IList<Custo
/// <param name="propertyInfo">The parameter which nullability info gets populated</param>
/// <exception cref="ArgumentNullException">If the propertyInfo parameter is null</exception>
/// <returns><see cref="NullabilityInfo" /></returns>
[RequiresUnreferencedCode("By default nullability attributes are trimmed by the trimmer")]
public NullabilityInfo Create(PropertyInfo propertyInfo)
{
if (propertyInfo is null)
Expand Down Expand Up @@ -232,6 +234,7 @@ private bool IsPrivateOrInternalMethodAndAnnotationDisabled(MethodInfo method)
/// <param name="eventInfo">The parameter which nullability info gets populated</param>
/// <exception cref="ArgumentNullException">If the eventInfo parameter is null</exception>
/// <returns><see cref="NullabilityInfo" /></returns>
[RequiresUnreferencedCode("By default nullability attributes are trimmed by the trimmer")]
public NullabilityInfo Create(EventInfo eventInfo)
{
if (eventInfo is null)
Expand All @@ -250,6 +253,7 @@ public NullabilityInfo Create(EventInfo eventInfo)
/// <param name="fieldInfo">The parameter which nullability info gets populated</param>
/// <exception cref="ArgumentNullException">If the fieldInfo parameter is null</exception>
/// <returns><see cref="NullabilityInfo" /></returns>
[RequiresUnreferencedCode("By default nullability attributes are trimmed by the trimmer")]
public NullabilityInfo Create(FieldInfo fieldInfo)
{
if (fieldInfo is null)
Expand Down
4 changes: 4 additions & 0 deletions src/libraries/System.Runtime/ref/System.Runtime.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11878,9 +11878,13 @@ public virtual void GetObjectData(System.Runtime.Serialization.SerializationInfo
}
public sealed class NullabilityInfoContext
{
[System.Diagnostics.CodeAnalysis.RequiresUnreferencedCodeAttribute("By default nullability attributes are trimmed by the trimmer")]
public System.Reflection.NullabilityInfo Create(System.Reflection.EventInfo eventInfo) { throw null; }
[System.Diagnostics.CodeAnalysis.RequiresUnreferencedCodeAttribute("By default nullability attributes are trimmed by the trimmer")]
public System.Reflection.NullabilityInfo Create(System.Reflection.FieldInfo fieldInfo) { throw null; }
[System.Diagnostics.CodeAnalysis.RequiresUnreferencedCodeAttribute("By default nullability attributes are trimmed by the trimmer")]
public System.Reflection.NullabilityInfo Create(System.Reflection.ParameterInfo parameterInfo) { throw null; }
[System.Diagnostics.CodeAnalysis.RequiresUnreferencedCodeAttribute("By default nullability attributes are trimmed by the trimmer")]
public System.Reflection.NullabilityInfo Create(System.Reflection.PropertyInfo propertyInfo) { throw null; }
}
public sealed class NullabilityInfo
Expand Down