Skip to content

Loop alignment: Handle blocks added in loop as part of split edges of LSRA #55047

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kunalspathak merged 4 commits into from
Jul 8, 2021
Merged

Loop alignment: Handle blocks added in loop as part of split edges of LSRA #55047

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2565e4d
Handle blocks added in loop as part of split edges of LSRA
kunalspathak Jul 1, 2021
5d777fa
Retain LOOP_ALIGN flag of loops whose start are same
kunalspathak Jul 2, 2021
aae9dcd
jit format
kunalspathak Jul 2, 2021
cd2004c
review feedback
kunalspathak Jul 8, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Retain LOOP_ALIGN flag of loops whose start are same
  • Loading branch information
@kunalspathak
kunalspathak committed Jul 2, 2021
commit 5d777fa92293bbf8fc2696c8e1e141e428446c2c
25 changes: 9 additions & 16 deletions src/coreclr/jit/emit.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4854,9 +4854,7 @@ void emitter::emitSetLoopBackEdge(BasicBlock* loopTopBlock)
emitLastLoopStart = currLoopStart;
emitLastLoopEnd = currLoopEnd;
}
// else if current loop completely encloses last loop,
// then current loop should not be aligned.
else if ((currLoopStart <= emitLastLoopStart) && (emitLastLoopEnd < currLoopEnd))
else if (currLoopStart == emitLastLoopStart)
{
// Note: If current and last loop starts at same point,
// retain the alignment flag of the smaller loop.
Expand All @@ -4868,23 +4866,18 @@ void emitter::emitSetLoopBackEdge(BasicBlock* loopTopBlock)
// | |
// |-----.
//
}
// else if current loop completely encloses last loop,
// then current loop should not be aligned.
else if ((currLoopStart < emitLastLoopStart) && (emitLastLoopEnd < currLoopEnd))
{
noAlignCurrentLoop = true;
}

// else if last loop completely encloses current loop,
// then last loop should not be aligned.
else if ((emitLastLoopStart <= currLoopStart) && (currLoopEnd < emitLastLoopEnd))
else if ((emitLastLoopStart < currLoopStart) && (currLoopEnd < emitLastLoopEnd))
{
// Note: If current and last loop starts at same point,
// retain the alignment flag of the smaller loop.
// |
// .---->|<----.
// last | | |
// loop | | | current
// | |-----. loop
// | |
// .---->|
//
noAlignLastLoop = true;
}
else
Expand All @@ -4907,7 +4900,7 @@ void emitter::emitSetLoopBackEdge(BasicBlock* loopTopBlock)
assert(!markedCurrLoop);
alignInstr->idaIG->igFlags &= ~IGF_LOOP_ALIGN;
markedCurrLoop = true;
JITDUMP("** Skip alignment for loop IG%02u ~ IG%02u because it encloses an aligned loop IG%02u ~ IG%02u.\n",
JITDUMP("** Skip alignment for current loop IG%02u ~ IG%02u because it encloses an aligned loop IG%02u ~ IG%02u.\n",
currLoopStart, currLoopEnd, emitLastLoopStart, emitLastLoopEnd);
}

Expand All @@ -4919,7 +4912,7 @@ void emitter::emitSetLoopBackEdge(BasicBlock* loopTopBlock)
assert(alignInstr->idaIG->isLoopAlign());
alignInstr->idaIG->igFlags &= ~IGF_LOOP_ALIGN;
markedLastLoop = true;
JITDUMP("** Skip alignment for loop IG%02u ~ IG%02u because it encloses an aligned loop IG%02u ~ IG%02u.\n",
JITDUMP("** Skip alignment for aligned loop IG%02u ~ IG%02u because it encloses the current loop IG%02u ~ IG%02u.\n",
emitLastLoopStart, emitLastLoopEnd, currLoopStart, currLoopEnd);
}

Expand Down