Skip to content

Add json support for F# options, lists, sets, maps and records #55108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
eiriktsarpalis merged 12 commits into from
Jul 15, 2021
Merged

Add json support for F# options, lists, sets, maps and records #55108

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
a8f594e
Add json support for F# options, lists, sets, maps and records
eiriktsarpalis Jul 2, 2021
2e1d449
fix ILLink warnings
eiriktsarpalis Jul 3, 2021
d9cc505
address ILLink annotations feedback
eiriktsarpalis Jul 12, 2021
ed8a0a5
add support for ValueOption
eiriktsarpalis Jul 12, 2021
e666c4f
revert unneeded sln changes
eiriktsarpalis Jul 13, 2021
12de895
add JsonIgnoreCondition tests for optional types
eiriktsarpalis Jul 13, 2021
967dd50
Revert "revert unneeded sln changes"
eiriktsarpalis Jul 13, 2021
e61a8da
remove lock from singleton initialization
eiriktsarpalis Jul 13, 2021
4e68e18
improve FSharp.Core missing member error mesages
eiriktsarpalis Jul 13, 2021
74a58f3
throw NotSupportedException on discriminated unions
eiriktsarpalis Jul 13, 2021
987e340
extend optional test coverage to include list, set and map payloads
eiriktsarpalis Jul 14, 2021
17a76a0
simplify changes required to converter infrastructure
eiriktsarpalis Jul 15, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
extend optional test coverage to include list, set and map payloads
  • Loading branch information
@eiriktsarpalis
eiriktsarpalis committed Jul 15, 2021
commit 987e340776a89d3bb426b13fb8431fd3539c5788
3 changes: 3 additions & 0 deletions src/libraries/System.Text.Json/tests/System.Text.Json.FSharp.Tests/OptionTests.fs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,9 @@ let getOptionalElementInputs() = seq {
wrap (3,2)
wrap {| Name = "Mary" ; Age = 32 |}
wrap struct {| Name = "Mary" ; Age = 32 |}
wrap [false; true; false; false]
wrap (Set.ofSeq [1 .. 5])
wrap (Map.ofSeq [("key1", "value1"); ("key2", "value2")])
}

[<Theory>]
Expand Down
3 changes: 3 additions & 0 deletions src/libraries/System.Text.Json/tests/System.Text.Json.FSharp.Tests/ValueOptionTests.fs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,9 @@ let getOptionalElementInputs() = seq {
wrap (3,2)
wrap {| Name = "Mary" ; Age = 32 |}
wrap struct {| Name = "Mary" ; Age = 32 |}
wrap [false; true; false; false]
wrap (Set.ofSeq [1 .. 5])
wrap (Map.ofSeq [("key1", "value1"); ("key2", "value2")])
}

[<Theory>]
Expand Down