Skip to content

Don't try to acquire a shared filed lock on Unix as it's not supported by NFS and CIFS #55195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
adamsitnik wants to merge 3 commits into from
Closed

Don't try to acquire a shared filed lock on Unix as it's not supported by NFS and CIFS #55195

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
48682c6
build .NET 5 Compat tests for Unix as well
adamsitnik Jul 2, 2021
fd341bf
don't try to aquire an advisory shared lock on Unix as it's not prope…
adamsitnik Jul 2, 2021
f10df36
Merge remote-tracking branch 'upstream/main' into fileLocking
adamsitnik Jul 6, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
build .NET 5 Compat tests for Unix as well
  • Loading branch information
@adamsitnik
adamsitnik committed Jul 2, 2021
commit 48682c6b4cb1ba0db538e8d96eddaa2cc134db12
3 changes: 1 addition & 2 deletions ...s/System.IO.FileSystem/tests/Net5CompatTests/System.IO.FileSystem.Net5Compat.Tests.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,7 @@
<PropertyGroup>
<AllowUnsafeBlocks>true</AllowUnsafeBlocks>
<IncludeRemoteExecutor>true</IncludeRemoteExecutor>
<!-- Windows is currently the only OS for which we provide a new strategy, so we test the Net5Compat only for Windows -->
<TargetFrameworks>$(NetCoreAppCurrent)-windows</TargetFrameworks>
<TargetFrameworks>$(NetCoreAppCurrent)-windows;$(NetCoreAppCurrent)-Unix;</TargetFrameworks>

<WasmXHarnessMonoArgs>--working-dir=/test-dir</WasmXHarnessMonoArgs>
</PropertyGroup>
Expand Down