Skip to content

[mono][debugger] Support debug after hot-reload #55220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thaystg merged 13 commits into from
Jul 13, 2021
Merged

[mono][debugger] Support debug after hot-reload #55220

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
45aa206
Add test case for debug after hot reload.
thaystg Jul 1, 2021
946c391
Merge remote-tracking branch 'origin/main' into thays_hot_reload_debug
thaystg Jul 2, 2021
5164999
Implementing debug after hot reload, on runtime side, and on client s…
thaystg Jul 6, 2021
e8bbbfc
Reuse some code.
thaystg Jul 6, 2021
79e00bf
Remove unrelated comment.
thaystg Jul 6, 2021
84de82a
Reuse code.
thaystg Jul 6, 2021
38712ad
Refactor new code.
thaystg Jul 6, 2021
f13a500
Fix log.
thaystg Jul 6, 2021
781969b
Apply suggestions from code review
thaystg Jul 7, 2021
e337da5
Fixing hot reload without debug information.
thaystg Jul 7, 2021
48d285d
replacing spaces with tabs.
thaystg Jul 7, 2021
fb9a4f1
Fixing CI.
thaystg Jul 12, 2021
0736c69
Merge branch 'main' into thays_hot_reload_debug
thaystg Jul 12, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Apply suggestions from code review 
Co-authored-by: Aleksey Kliger (λgeek) <[email protected]>
  • Loading branch information
@thaystg @lambdageek
thaystg and lambdageek authored Jul 7, 2021
commit 781969b6a23a993ee726b40f3e8d1ef2675d7d31
1 change: 0 additions & 1 deletion src/mono/mono/metadata/icall.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5776,7 +5776,6 @@ ves_icall_AssemblyExtensions_ApplyUpdate (MonoAssembly *assm,
g_assert (dmeta_len >= 0);
MonoImage *image_base = assm->image;
g_assert (image_base);
// TODO: use dpdb_bytes

mono_image_load_enc_delta (image_base, dmeta_bytes, dmeta_len, dil_bytes, dil_len, dpdb_bytes, dpdb_len, error);

Expand Down
6 changes: 3 additions & 3 deletions src/mono/wasm/debugger/tests/ApplyUpdateReferencedAssembly/MethodBody1_v2.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,9 +26,9 @@ public static string StaticMethod1 () {

public class MethodBody3 {
public static string StaticMethod3 () {
bool c = true;
Console.WriteLine("v2");
return "NEWEST STRING";
bool c = true;
Console.WriteLine("v2");
return "NEWEST STRING";
}
}
}