Clean-up sendtohelix and fix prop ordering issue #55265
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The ordering issue was discovered in #55074 (comment). Fixing it by not reading from properties which aren't defined in props inside the project file but from within an initial target.
ghost
added
the
|
Tagging subscribers to this area: @Anipik, @safern, @ViktorHofer Issue DetailsThe ordering issue was discovered in #55074 (comment). Fixing it by not reading from properties which aren't defined in props inside the project file but from within an initial target.
|
Member
Author
|
@safern as I'm out now the next two weeks, feel free to merge when CI is green. |
Anipik
approved these changes
Jul 8, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ordering issue was discovered in #55074 (comment). Fixing it by not reading from properties which aren't defined in props inside the project file but from within an initial target.
NetCoreAppCurrentBuildSettingsis defined in a targets file as it relies on properties which could be changed inside a project. That said, that's usually not the case for projects under src/libraries/.