Skip to content

Sync HPack encoding changes from aspnetcore #55288

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Tratcher merged 2 commits into from
Jul 8, 2021
Merged

Sync HPack encoding changes from aspnetcore #55288

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d745fae
Sync HPack encoding changes from aspnetcore
Tratcher Jul 7, 2021
d1a36e3
Add valueEncoding to call
Tratcher Jul 7, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Add valueEncoding to call
  • Loading branch information
@Tratcher
Tratcher committed Jul 7, 2021
commit d1a36e3a6f7e96a2347e95dd54bdf5187dd88688
2 changes: 1 addition & 1 deletion src/libraries/System.Net.Http/src/System/Net/Http/SocketsHttpHandler/Http2Connection.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1062,7 +1062,7 @@ private void WriteIndexedHeader(int index, string value, ref ArrayBuffer headerB
if (NetEventSource.Log.IsEnabled()) Trace($"{nameof(index)}={index}, {nameof(value)}={value}");

int bytesWritten;
while (!HPackEncoder.EncodeLiteralHeaderFieldWithoutIndexing(index, value, headerBuffer.AvailableSpan, out bytesWritten))
while (!HPackEncoder.EncodeLiteralHeaderFieldWithoutIndexing(index, value, valueEncoding: null, headerBuffer.AvailableSpan, out bytesWritten))
{
headerBuffer.EnsureAvailableSpace(headerBuffer.AvailableLength + 1);
}
Expand Down