Skip to content

Add ConfigurationManager #55338

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
halter73 merged 6 commits into from
Jul 13, 2021
Merged

Add ConfigurationManager #55338

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
4ab202c
Add Config : IConfigurationRoot, IConfigurationBuilder
halter73 Jul 8, 2021
eb99621
Use resource string
halter73 Jul 8, 2021
5f067dc
Share some logic with ConfigurationRoot
halter73 Jul 12, 2021
0f7448c
Remove "Maybe we should change that" comment
halter73 Jul 12, 2021
c8e2839
ConfigTests -> ConfigTest
halter73 Jul 12, 2021
09d7471
Config -> ConfigurationManager
halter73 Jul 12, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Use resource string
  • Loading branch information
@halter73
halter73 committed Jul 8, 2021
commit eb99621dbd4ead612d273994845b144890f544ff
2 changes: 1 addition & 1 deletion src/libraries/Microsoft.Extensions.Configuration/src/Config.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ public string this[string key]
{
if (_providers.Count == 0)
{
throw new InvalidOperationException("A configuration source is not registered. Please register one before setting a value.");
throw new InvalidOperationException(SR.Error_NoSources);
}

foreach (var provider in _providers)
Expand Down
4 changes: 1 addition & 3 deletions src/libraries/Microsoft.Extensions.Configuration/tests/ConfigTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -740,13 +740,11 @@ public void SetValueThrowsExceptionNoSourceRegistered()

((IConfigurationBuilder)config).Sources.Clear();

var expectedMsg = "A configuration source is not registered. Please register one before setting a value.";

// Act
var ex = Assert.Throws<InvalidOperationException>(() => config["Title"] = "Welcome");

// Assert
Assert.Equal(expectedMsg, ex.Message);
Assert.Equal(SR.Error_NoSources, ex.Message);
}

[Fact]
Expand Down