Skip to content

use O_TRUNC when file locking is disabled, avoid ftruncate syscall #55456

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
adamsitnik merged 5 commits into from
Jul 10, 2021
Merged

use O_TRUNC when file locking is disabled, avoid ftruncate syscall #55456

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
614a333
add test project with file locking disabled via config file
adamsitnik Jul 10, 2021
d461f14
use O_TRUNC when file locking is disabled, avoid ftruncate syscall
adamsitnik Jul 10, 2021
af8ffdd
Apply suggestions from code review
adamsitnik Jul 10, 2021
8baac45
apply code review suggestions
adamsitnik Jul 10, 2021
f6ec1f9
reduce the number of tests in DisabledFileLocking from 6270 to 1429
adamsitnik Jul 10, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Apply suggestions from code review 
Co-authored-by: Stephen Toub <[email protected]>
  • Loading branch information
@adamsitnik @stephentoub
adamsitnik and stephentoub authored Jul 10, 2021
commit af8ffdd7b64675145ad6a6e60a586bc9d4677bde
4 changes: 2 additions & 2 deletions src/libraries/Common/tests/TestUtilities/System/PlatformDetection.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -290,9 +290,9 @@ private static Version GetICUVersion()

public static bool IsNet5CompatFileStreamEnabled => _net5CompatFileStream.Value;

private static readonly Lazy<bool> _fileLockingDisabled = new Lazy<bool>(() => GetStaticNonPublicBooleanPropertyValue("Microsoft.Win32.SafeHandles.SafeFileHandle", "DisableFileLocking"));
private static readonly Lazy<bool> s_fileLockingDisabled = new Lazy<bool>(() => GetStaticNonPublicBooleanPropertyValue("Microsoft.Win32.SafeHandles.SafeFileHandle", "DisableFileLocking"));

public static bool IsFileLockingEnabled => IsWindows || !_fileLockingDisabled.Value;
public static bool IsFileLockingEnabled => IsWindows || !s_fileLockingDisabled.Value;

private static bool GetIsInContainer()
{
Expand Down