Skip to content

[wasm] [debugger] Support method calls #55458

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thaystg merged 8 commits into from
Jul 14, 2021
Merged

[wasm] [debugger] Support method calls #55458

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
d3b52af
Implement method calls and method calls with simple parameters.
thaystg Jul 10, 2021
43257f3
removing useless change.
thaystg Jul 10, 2021
acf758c
Support const char.
thaystg Jul 10, 2021
4039ce6
Adding more tests as suggested by @pavelsavara.
thaystg Jul 12, 2021
198ab2b
Adding a test calling a method that returns void and change an attrib…
thaystg Jul 13, 2021
7f5ee6c
Changing what @pavelsavara suggested.
thaystg Jul 14, 2021
044bbf9
Merge branch 'main' into thays_implement_method_calls_watch
thaystg Jul 14, 2021
5c0f419
Fix merge.
thaystg Jul 14, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
removing useless change.
  • Loading branch information
@thaystg
thaystg committed Jul 10, 2021
commit 43257f33ac46b178b8ef5bd2f2007b857700b767
5 changes: 3 additions & 2 deletions src/mono/wasm/debugger/BrowserDebugProxy/EvaluateExpression.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,9 +27,7 @@ private class FindVariableNMethodCall : CSharpSyntaxWalker
public List<InvocationExpressionSyntax> methodCall = new List<InvocationExpressionSyntax>();
public List<MemberAccessExpressionSyntax> memberAccesses = new List<MemberAccessExpressionSyntax>();
public List<object> argValues = new List<object>();
public Dictionary<string, string> memberAccessToParamName = new Dictionary<string, string>();
public Dictionary<string, JObject> memberAccessValues = new Dictionary<string, JObject>();
public Dictionary<string, string> methodCallToParamName = new Dictionary<string, string>();
private int visitCount;

public void VisitInternal(SyntaxNode node)
Expand Down Expand Up @@ -73,6 +71,9 @@ public override void Visit(SyntaxNode node)

public SyntaxTree ReplaceVars(SyntaxTree syntaxTree, IEnumerable<JObject> ma_values, IEnumerable<JObject> id_values, IEnumerable<JObject> method_values)
{
var memberAccessToParamName = new Dictionary<string, string>();
var methodCallToParamName = new Dictionary<string, string>();

CompilationUnitSyntax root = syntaxTree.GetCompilationUnitRoot();

// 1. Replace all this.a occurrences with this_a_ABDE
Expand Down