Skip to content

Use O_APPEND and FILE_APPEND_DATA to allow for atomic file appends #55465

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
adamsitnik wants to merge 7 commits into from
Closed

Use O_APPEND and FILE_APPEND_DATA to allow for atomic file appends #55465

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
7d3ead2
use O_APPEND for atomic appends, support handles opened with APPEND
adamsitnik Jul 10, 2021
f847b83
Merge remote-tracking branch 'upstream/main' into o_append
adamsitnik Jul 10, 2021
1aa4086
Windows implementation
adamsitnik Jul 10, 2021
0bc6750
Merge remote-tracking branch 'upstream/main' into o_append
adamsitnik Aug 19, 2021
ebe3078
"Trying to seek to a position before the end of the file throws an IO…
adamsitnik Aug 19, 2021
f210ab8
Update src/libraries/System.Private.CoreLib/src/Microsoft/Win32/SafeH…
adamsitnik Aug 19, 2021
aa34427
fix the Unix build
adamsitnik Aug 19, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fix the Unix build
  • Loading branch information
@adamsitnik
adamsitnik committed Aug 19, 2021
commit aa344274a253eccf5deb7c11a7cfddd5ba86bf55
2 changes: 1 addition & 1 deletion src/libraries/System.Private.CoreLib/src/System/IO/RandomAccess.Unix.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,7 @@ internal static unsafe void WriteAtOffset(SafeFileHandle handle, ReadOnlySpan<by

// POSIX requires that pwrite should respect provided offset even for handles opened with O_APPEND.
// But Linux and BSD don't do that, moreover their behaviour is different. So we always use write for O_APPEND.
int bytesWritten = handle.CanSeek && !handle.IsAppend
int bytesWritten = handle.CanSeek && !handle.IsAppend
? Interop.Sys.PWrite(handle, bufPtr, GetNumberOfBytesToWrite(buffer.Length), fileOffset)
: Interop.Sys.Write(handle, bufPtr, GetNumberOfBytesToWrite(buffer.Length));
FileStreamHelpers.CheckFileCall(bytesWritten, handle.Path);
Expand Down