Skip to content

Compression.ZipFile support for Unix Permissions #55531

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
eerhardt merged 9 commits into from
Jul 14, 2021
Merged

Compression.ZipFile support for Unix Permissions #55531

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
60c64ca
Compression.ZipFile support for Unix Permissions
eerhardt Jul 12, 2021
d52fce0
Add unit tests
eerhardt Jul 12, 2021
d4f1821
Fix build
eerhardt Jul 12, 2021
db4f43a
Fix windows build
eerhardt Jul 13, 2021
1d012c5
Add Browser TFM
eerhardt Jul 13, 2021
f7f2078
Fix tests on wasm
eerhardt Jul 13, 2021
04e929e
PR feedback. Add more ZipFile tests
eerhardt Jul 13, 2021
fe69ae7
Fix build
eerhardt Jul 13, 2021
5b57040
Fix test on wasm
eerhardt Jul 13, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix tests on wasm
  • Loading branch information
@eerhardt
eerhardt committed Jul 13, 2021
commit f7f20785fb1f7f51c6c37f9d472e51303f3747ef
1 change: 1 addition & 0 deletions src/libraries/System.IO.Compression.ZipFile/tests/System.IO.Compression.ZipFile.Tests.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@
<ItemGroup Condition=" '$(TargetsUnix)' == 'true' or '$(TargetsBrowser)' == 'true' ">
<Compile Include="ZipFile.Unix.cs" />
<Compile Include="$(CommonPath)Interop\Unix\Interop.Libraries.cs" Link="Interop\Unix\Interop.Libraries.cs" />
<Compile Include="$(CommonPath)Interop\Unix\System.Native\Interop.ChMod.cs" Link="Interop\Unix\System.Native\Interop.ChMod.cs" />
<Compile Include="$(CommonPath)Interop\Unix\System.Native\Interop.Stat.cs" Link="Interop\Unix\System.Native\Interop.Stat.cs" />
</ItemGroup>
<ItemGroup>
Expand Down
9 changes: 1 addition & 8 deletions src/libraries/System.IO.Compression.ZipFile/tests/ZipFile.Unix.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,15 +96,8 @@ private static void CreateFile(string folderPath, string permissions)
{
string filename = Path.Combine(folderPath, $"{permissions}.txt");
File.WriteAllText(filename, "contents");
ChMod(filename, permissions);
}

[DllImport("libc")]
private static extern int chmod(string path, int mode);

private static void ChMod(string filename, string mode)
{
Assert.Equal(0, chmod(filename, Convert.ToInt32(mode, 8)));
Assert.Equal(0, Interop.Sys.ChMod(filename, Convert.ToInt32(permissions, 8)));
}

private static void EnsureFilePermissions(string filename, string permissions)
Expand Down