Skip to content

Add tests for generic types/values with the Marshal APIs #55533

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jkoritzinsky merged 4 commits into from
Jul 14, 2021
Merged

Add tests for generic types/values with the Marshal APIs #55533

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d460c2a
Add tests for generic types for Marshal.OffsetOf
jkoritzinsky Jul 12, 2021
dc63430
Fix test name.
jkoritzinsky Jul 12, 2021
26fc4d1
Remove string case since it gets a canonical instantiation sometimes …
jkoritzinsky Jul 12, 2021
6be611d
Add some more tests for OffsetOf, PtrToStructure, and SizeOf that wor…
jkoritzinsky Jul 13, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Remove string case since it gets a canonical instantiation sometimes … 
…depending on optimization settings.
  • Loading branch information
@jkoritzinsky
jkoritzinsky committed Jul 12, 2021
commit 26fc4d16e2f302d541b97ccfa1c2ea87591a0eef
3 changes: 1 addition & 2 deletions ...tem.Runtime.InteropServices/tests/System/Runtime/InteropServices/Marshal/OffsetOfTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -232,11 +232,10 @@ public void OffsetOf_Field_Generic()
Assert.Equal((IntPtr)4, Marshal.OffsetOf<Point2<float>>(nameof(Point2<int>.y)));
Assert.Equal((IntPtr)8, Marshal.OffsetOf<Point2<double>>(nameof(Point2<int>.y)));

// [COMPAT] Non-blittable generic types are supported in OffsetOf since they've always been allowed
// [COMPAT] Non-blittable generic types with value-type generic arguments are supported in OffsetOf since they've always been allowed
// and it likely doesn't meet the bar to break back-compat.
Assert.Equal((IntPtr)1, Marshal.OffsetOf<Point2<char>>(nameof(Point2<int>.y)));
Assert.Equal((IntPtr)1, Marshal.OffsetOf<Point2<byte>>(nameof(Point2<int>.y)));
Assert.Equal((IntPtr)IntPtr.Size, Marshal.OffsetOf<Point2<string>>(nameof(Point2<int>.y)));
}

public class NonRuntimeType : Type
Expand Down