[mono][wasm] Mark memcpy LLVM instructions as volatile when they are … #55598
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…used to copy valuetypes containing references. This is needed to make sure llvm keeps the valuetypes on the C stack for GC tracking. Fixes random crashes when running the System.Collections.NonGeneric testsuite.
ghost
added
the
thaystg
approved these changes
Jul 14, 2021
imhameed
approved these changes
Jul 14, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…used to copy
valuetypes containing references. This is needed to make sure llvm keeps the valuetypes
on the C stack for GC tracking.
Fixes random crashes when running the System.Collections.NonGeneric testsuite.