Skip to content

Conversation

@tlakollo
Copy link
Contributor

Add an overload to RequiresAssemblyFiles to be able to have the same user experience as if using RequiresUnreferencedCode
Fixes #55274

user experience as if using RequiresUnreferencedCode
@tlakollo tlakollo self-assigned this Jul 14, 2021
@tlakollo tlakollo requested a review from marek-safar as a code owner July 14, 2021 05:44
@ghost
Copy link

ghost commented Jul 14, 2021

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, to please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

@ghost
Copy link

ghost commented Jul 14, 2021

Tagging subscribers to this area: @agocke, @vitek-karas, @VSadov
See info in area-owners.md if you want to be subscribed.

Issue Details

Add an overload to RequiresAssemblyFiles to be able to have the same user experience as if using RequiresUnreferencedCode
Fixes #55274

Author: tlakollo
Assignees: tlakollo
Labels:

area-Single-File, new-api-needs-documentation

Milestone: -

@tlakollo tlakollo merged commit bf014b5 into dotnet:main Jul 14, 2021
@tlakollo tlakollo deleted the UnifyRequiresAttribute branch July 14, 2021 19:09
}

/// <summary>
/// Gets or sets an optional message that contains information about the need for
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

or sets should be removed from the docs

@ghost ghost locked as resolved and limited conversation to collaborators Aug 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unify RequiresUnreferencedCode and RequiresAssemblyFiles attributes

3 participants