Skip to content

Annotate WebSockets.RegisterPrefixes with [Obsolete] #55640

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
alnikola merged 3 commits into from
Jul 16, 2021
Merged

Annotate WebSockets.RegisterPrefixes with [Obsolete] #55640

alnikola merged 3 commits into from
Jul 16, 2021

Conversation

@alnikola
Copy link
Contributor

@alnikola alnikola commented Jul 14, 2021

Fixes #50530

@alnikola alnikola requested a review from a team July 14, 2021 13:13
@ghost ghost added the area-System.Net label Jul 14, 2021
@ghost
Copy link

ghost commented Jul 14, 2021

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Issue Details

Fixes #50530

Author: alnikola
Assignees: -
Labels:

area-System.Net
Milestone: -

@stephentoub
Copy link
Member

stephentoub commented Jul 14, 2021 •
edited
Loading

Did we discuss this one in API review?

Does it need a unique diagnostic ID or we're ok just with the general ID? (In this particular case I personally think the general ID is fine and it doesn't need to be assigned a unique one.)

The ref needs to be updated accordingly as well.

@alnikola
Copy link
Contributor Author

alnikola commented Jul 14, 2021

@stephentoub Sorry, I didn't know that an API review is required for this since the issue #50530 explicitly asks to do it and a similar thing was done for QUIC API #49261.
Should I close this PR then?

@stephentoub
Copy link
Member

stephentoub commented Jul 14, 2021

Should I close this PR then?

No, this one's pretty simple. @bartonjs, @terrajobst, any concerns? This API is useless and is already hidden.

@bartonjs
Copy link
Member

bartonjs commented Jul 14, 2021

any concerns?

Not from me. I like Obsoleting things 😄.

It'd be a good idea to fix the tests so they compile, though 😏

@alnikola
Copy link
Contributor Author

alnikola commented Jul 15, 2021

Build fixed.

@alnikola alnikola merged commit 5519852 into main Jul 16, 2021
@alnikola alnikola deleted the alnikola/ann-ws-registerprefixes branch July 16, 2021 09:37
@ManickaP ManickaP mentioned this pull request Jul 20, 2021
Merged
@karelz karelz added this to the 6.0.0 milestone Jul 22, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Aug 21, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@stephentoub stephentoub stephentoub approved these changes

Assignees

No one assigned

Labels

area-System.Net

Projects

None yet

Milestone

6.0.0

Development

Successfully merging this pull request may close these issues.

Annotate unsupported APIs in System.Net

5 participants

@alnikola @stephentoub @bartonjs @karelz