Skip to content

Remove sourceFullPath from Unix FileSystem.MoveDirectory exception #55658

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
stephentoub merged 8 commits into from
Jul 16, 2021
Merged

Remove sourceFullPath from Unix FileSystem.MoveDirectory exception #55658

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
16270cd
Update Path.Windows.cs
steveberdy Jul 8, 2021
086bae8
Merge branch 'dotnet:main' into main
steveberdy Jul 8, 2021
ce6bfd2
Change helper method to internal
steveberdy Jul 9, 2021
bdd1e36
Merge branch 'dotnet:main' into main
steveberdy Jul 12, 2021
80cbbe2
Merge branch 'dotnet:main' into main
steveberdy Jul 13, 2021
b88008d
Removed sourceFullPath from Unix FileSystem.MoveDirectory thrown exce…
steveberdy Jul 14, 2021
7890ab4
Undo commit from main fork branch
steveberdy Jul 14, 2021
208b9f4
Revert FileSystem.Windows.cs changes
steveberdy Jul 15, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Change helper method to internal 
Switched method from a private protection level to an internal protection level. Also removed trailing whitespace.
  • Loading branch information
@steveberdy
steveberdy authored Jul 9, 2021
commit ce6bfd26b32b71c2460088a79c3b2cdc7360e14a
6 changes: 3 additions & 3 deletions src/libraries/System.Private.CoreLib/src/System/IO/Path.Windows.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ public static string GetFullPath(string path)
// unpredictable results.
if (path.Contains('\0'))
throw new ArgumentException(SR.Argument_InvalidPathChars, nameof(path));

return GetFullQualifiedPath(path);
}

Expand Down Expand Up @@ -122,8 +122,8 @@ public static string GetFullPath(string path, string basePath)
? PathInternal.RemoveRelativeSegments(combinedPath, PathInternal.GetRootLength(combinedPath.AsSpan()))
: GetFullQualifiedPath(combinedPath);
}
private static string GetFullQualifiedPath(string path)

internal static string GetFullQualifiedPath(string path)
{
if (PathInternal.IsExtended(path.AsSpan()))
{
Expand Down