Skip to content

Improve TryTransformStoreObjAsStoreInd optimization. #55727

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sandreenko merged 2 commits into from
Jul 15, 2021
Merged

Improve TryTransformStoreObjAsStoreInd optimization. #55727

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
05c201c
Fix `TryTransformStoreObjAsStoreInd` optimization.
Jul 15, 2021
ab28a4e
Disable the assert.
Jul 15, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Disable the assert. 
It was failing on DevDiv_280120 arm32 linux, did not repro with an altjit.
  • Loading branch information
Sergey committed Jul 15, 2021
commit ab28a4e81a1c2a839d574d680c2dccb3d2ae5686
2 changes: 0 additions & 2 deletions src/coreclr/jit/lowerarmarch.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -306,8 +306,6 @@ void Lowering::LowerBlockStore(GenTreeBlk* blkNode)
{
// TODO-1stClassStructs: for now we can't work with STORE_BLOCK source in register.
const unsigned srcLclNum = src->AsLclVar()->GetLclNum();
INDEBUG(const LclVarDsc* lvlVar = comp->lvaGetDesc(srcLclNum););
assert(comp->lvaVarDoNotEnregister(srcLclNum) || lvlVar->HasGCPtr());
comp->lvaSetVarDoNotEnregister(srcLclNum DEBUGARG(Compiler::DNER_BlockOp));
}

Expand Down
2 changes: 0 additions & 2 deletions src/coreclr/jit/lowerxarch.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -280,8 +280,6 @@ void Lowering::LowerBlockStore(GenTreeBlk* blkNode)
{
// TODO-1stClassStructs: for now we can't work with STORE_BLOCK source in register.
const unsigned srcLclNum = src->AsLclVar()->GetLclNum();
INDEBUG(const LclVarDsc* lvlVar = comp->lvaGetDesc(srcLclNum););
assert(comp->lvaVarDoNotEnregister(srcLclNum) || lvlVar->HasGCPtr());
comp->lvaSetVarDoNotEnregister(srcLclNum DEBUGARG(Compiler::DNER_BlockOp));
}

Expand Down