Skip to content

Make Named Pipe Server Stream name fit into allowed length on Android #55731

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
stephentoub merged 6 commits into from
Jul 16, 2021
Merged

Make Named Pipe Server Stream name fit into allowed length on Android #55731

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
edb56fa
Make Named Pipe Server Stream name fit into allowed length on Android
MaximLipnin Jul 15, 2021
6d1c7e2
Apply Stephen's suggestion
MaximLipnin Jul 15, 2021
a2ce08e
Merge branch 'main' into issue_55689
MaximLipnin Jul 16, 2021
1b7b300
Remove redundant parameter
MaximLipnin Jul 16, 2021
5d6030e
Merge branch 'main' into issue_55689
MaximLipnin Jul 16, 2021
5c21fe7
Take into account possible null terminator
MaximLipnin Jul 16, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Remove redundant parameter
  • Loading branch information
@MaximLipnin
MaximLipnin committed Jul 16, 2021
commit 1b7b300e68bb7c4bf32cf7507ea023b55f006dae
2 changes: 1 addition & 1 deletion src/libraries/System.IO.FileSystem/tests/FileSystemTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ public static string GetNamedPipeServerStreamName()
const int MinAvailableForSufficientRandomness = 5; // we want enough randomness in the name to avoid conflicts between concurrent tests
string prefix = Path.Combine(Path.GetTempPath(), "CoreFxPipe_");
int availableLength = MinUdsPathLength - prefix.Length;
Assert.True(availableLength >= MinAvailableForSufficientRandomness, int.MaxValue, $"UDS prefix {prefix} length {prefix.Length} is too long");
Assert.True(availableLength >= MinAvailableForSufficientRandomness, $"UDS prefix {prefix} length {prefix.Length} is too long");

return string.Create(availableLength, 0, (span, _) =>
{
Expand Down