Remove unnecessary intrinsics in mono/mini/intrinsics.c #55806
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- System.Environment.IsRunningOnWindows doesn't exist in the dotnet/runtime corelib - Microsoft.CodeAnalysis.CompilerServer.MemoryHelper.IsMemoryAvailable was used to workaround a bug that was fixed 2 years ago with dotnet/roslyn#38239 and should no longer be relevant
akoeplinger
requested review from
SamMonoRT,
imhameed,
lambdageek and
vargaz
as code owners
ghost
added
the
marek-safar
approved these changes
Jul 16, 2021
vargaz
approved these changes
Jul 16, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
System.Environment.IsRunningOnWindowsdoesn't exist in the dotnet/runtime corelibMicrosoft.CodeAnalysis.CompilerServer.MemoryHelper.IsMemoryAvailablewas used to workaround a bug that was fixed 2 years ago with MemoryHelper.cs: Don't call Win32 API on Unix roslyn#38239 and should no longer be relevant