Skip to content

Add --debuginfo to superpmi #55808

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jakobbotsch merged 1 commit into from
Jul 19, 2021
Merged

Add --debuginfo to superpmi #55808

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Add --debuginfo to superpmi
  • Loading branch information
@jakobbotsch
jakobbotsch committed Jul 16, 2021
commit 8df0bb6b1251870b7dff4363f26387ebdf111389
11 changes: 11 additions & 0 deletions src/coreclr/scripts/superpmi.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -308,6 +308,7 @@
asm_diff_parser.add_argument("--diff_jit_dump", action="store_true", help="Generate JitDump output for diffs. Default: only generate asm, not JitDump.")
asm_diff_parser.add_argument("-temp_dir", help="Specify a temporary directory used for a previous ASM diffs run (for which --skip_cleanup was used) to view the results. The replay command is skipped.")
asm_diff_parser.add_argument("--gcinfo", action="store_true", help="Include GC info in disassembly (sets COMPlus_JitGCDump/COMPlus_NgenGCDump; requires instructions to be prefixed by offsets).")
asm_diff_parser.add_argument("--debuginfo", action="store_true", help="Include debug info after disassembly (sets COMPlus_JitDebugDump/COMPlus_NgenDebugDump).")
asm_diff_parser.add_argument("-base_jit_option", action="append", help="Option to pass to the baseline JIT. Format is key=value, where key is the option name without leading COMPlus_...")
asm_diff_parser.add_argument("-diff_jit_option", action="append", help="Option to pass to the diff JIT. Format is key=value, where key is the option name without leading COMPlus_...")
asm_diff_parser.add_argument("-tag", help="Specify a word to add to the directory name where the asm diffs will be placed")
Expand Down Expand Up @@ -1718,6 +1719,11 @@ def replay_with_asm_diffs(self):
"COMPlus_JitGCDump": "*",
"COMPlus_NgenGCDump": "*" })

if self.coreclr_args.debuginfo:
asm_complus_vars.update({
"COMPlus_JitDebugDump": "*",
"COMPlus_NgenDebugDump": "*" })

jit_dump_complus_vars = asm_complus_vars.copy()
jit_dump_complus_vars.update({
"COMPlus_JitDump": "*",
Expand Down Expand Up @@ -3635,6 +3641,11 @@ def verify_replay_common_args():
lambda unused: True,
"Unable to set gcinfo.")

coreclr_args.verify(args,
"debuginfo",
lambda unused: True,
"Unable to set debuginfo.")

coreclr_args.verify(args,
"diff_jit_dump",
lambda unused: True,
Expand Down