Skip to content

Refactor runtime-specific logic out of CustomAttributeData #55870

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jkotas merged 12 commits into from
Jul 17, 2021
Merged

Refactor runtime-specific logic out of CustomAttributeData #55870

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
c1bb326
Refactor runtime-specific logic out of CustomAttributeData
jkotas Jul 17, 2021
6d6274e
Fix linker build break
jkotas Jul 17, 2021
00aa646
Simplify CanonicalizeValue
jkotas Jul 17, 2021
10890e0
Use pattern matching
jkotas Jul 17, 2021
24ba08c
Update src/libraries/System.Private.CoreLib/src/System/Reflection/Cus…
jkotas Jul 17, 2021
9a3841d
Feedback
jkotas Jul 17, 2021
7825aab
Merge remote-tracking branch 'origin/customattributedata' into custom…
jkotas Jul 17, 2021
26f880a
Fix bad merge
jkotas Jul 17, 2021
2275e34
Revert incorrect change
jkotas Jul 17, 2021
0bcb0f1
Is this hitting codegen bug?
jkotas Jul 17, 2021
dcd0e38
Fix Mono ICALL order
jkotas Jul 17, 2021
e9b68dc
Revert incorrect change
jkotas Jul 17, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Is this hitting codegen bug?
  • Loading branch information
@jkotas
jkotas committed Jul 17, 2021
commit 0bcb0f1e77e4dd7fe15ec85bc3cb2c7505c5a16e
2 changes: 2 additions & 0 deletions src/libraries/System.Private.CoreLib/src/System/Reflection/CustomAttributeData.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
// The .NET Foundation licenses this file to you under the MIT license.

using System.Collections.Generic;
using System.Runtime.CompilerServices;
using System.Text;

namespace System.Reflection
Expand Down Expand Up @@ -47,6 +48,7 @@ protected CustomAttributeData()
}

#region Object Override
[MethodImpl(MethodImplOptions.NoOptimization)] // Workaround for codegen bug?
public override string ToString()
{
var vsb = new ValueStringBuilder(stackalloc char[256]);
Expand Down