Implement new way of return address hijacking #55946
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change implements a new way of return address hijacking for Intel CET enabled Windows devices. It uses a mechanism created by the Windows team for this purpose. The existing mechanism that just patches the return address by an address of our helper routine would result in process killing as it would seem like a ROP exploit.
kouvel
approved these changes
Jul 22, 2021
| endif (CLR_CMAKE_HOST_ARCH_I386) | ||
|
|
||
| if (CLR_CMAKE_HOST_ARCH_AMD64) | ||
| list (APPEND ASM_OPTIONS /guard:ehcont) |
Contributor
There was a problem hiding this comment.
I don't think this is necessary, I enabled the flag for all asm files in #55942
Member
Author
There was a problem hiding this comment.
Ok, great! This was a remainder of my previous state.
src/coreclr/vm/wks/CMakeLists.txt
Outdated
| endif (CLR_CMAKE_HOST_ARCH_I386) | ||
|
|
||
| if (CLR_CMAKE_HOST_ARCH_AMD64) | ||
| set_source_files_properties(${VM_SOURCES_WKS_ARCH_ASM} PROPERTIES COMPILE_FLAGS "/guard:ehcont") |
Contributor
There was a problem hiding this comment.
I don't think this is necessary, I enabled the flag for all asm files in #55942
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change implements a new way of return address hijacking for Intel
CET enabled Windows devices. It uses a mechanism created by the Windows
team for this purpose. The existing mechanism that just patches the
return address by an address of our helper routine would result in
process killing as it would seem like a ROP exploit.
Contributes to #47309