Skip to content

[8/21 Infra rollout] update sdk to preview6 #56161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ViktorHofer merged 3 commits into from
Aug 2, 2021
Merged

[8/21 Infra rollout] update sdk to preview6 #56161

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2dc2382
update sdk to preview6
mangod9 Jul 22, 2021
b226190
Merge branch 'main' into upgradeTopreview6
mangod9 Jul 23, 2021
c378ca2
Remove invalid Castle.DynamicProxy.Internal.AbstractInvocation from I…
akoeplinger Jul 27, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Remove invalid Castle.DynamicProxy.Internal.AbstractInvocation from I… 
…LLink descriptor files

The type is actually in the `Castle.DynamicProxy` namespace, not the `.Internal` one.
This causes an error with newer linker versions.

The whole `Castle.DynamicProxy` namespace is already preserved so we can remove the entry for AbstractInvocation.
  • Loading branch information
@akoeplinger
akoeplinger committed Jul 27, 2021
commit c378ca263496dff2386dd12c16e0c13a542f70ad
1 change: 0 additions & 1 deletion eng/testing/ILLinkDescriptors/ILLink.Descriptors.Castle.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@
<assembly fullname="Castle.Core">
<namespace fullname="Castle.DynamicProxy" />
<type fullname="Castle.DynamicProxy.Internal.CompositionInvocation" />
<type fullname="Castle.DynamicProxy.Internal.AbstractInvocation" />
<type fullname="Castle.DynamicProxy.Internal.InheritanceInvocation" />
</assembly>
<assembly fullname="Moq">
Expand Down
1 change: 0 additions & 1 deletion src/libraries/System.ComponentModel.TypeConverter/tests/ILLink.Descriptors.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@
<assembly fullname="Castle.Core">
<namespace fullname="Castle.DynamicProxy" />
<type fullname="Castle.DynamicProxy.Internal.CompositionInvocation" />
<type fullname="Castle.DynamicProxy.Internal.AbstractInvocation" />
<type fullname="Castle.DynamicProxy.Internal.InheritanceInvocation" />
</assembly>
<assembly fullname="Moq">
Expand Down