Skip to content

Use ReflectionOnly as serialization mode in case dynamic code runtime feature is not supported #56604

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MaximLipnin merged 6 commits into from
Aug 3, 2021
Merged

Use ReflectionOnly as serialization mode in case dynamic code runtime feature is not supported #56604

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
ee62aa7
Use ReflectionOnly as serialization mode in case dynamic code runtime…
MaximLipnin Jul 30, 2021
168004e
Update src/libraries/System.Private.Xml/src/System/Xml/Serialization/…
MaximLipnin Jul 30, 2021
58df21e
Remove an unnecessary internal call
MaximLipnin Jul 30, 2021
88144ed
Revert Mode to usual property
MaximLipnin Jul 30, 2021
ffa032a
Merge branch 'main' into use_refelectiononly_for_xmlserializer
MaximLipnin Aug 2, 2021
426ad9f
Make Mode property linker-friendly
MaximLipnin Aug 2, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Make Mode property linker-friendly
  • Loading branch information
@MaximLipnin
MaximLipnin committed Aug 2, 2021
commit 426ad9f037d78bb78863a21868f492e895a4b520
8 changes: 7 additions & 1 deletion src/libraries/System.Private.Xml/src/System/Xml/Serialization/XmlSerializer.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,13 @@ internal enum SerializationMode

public class XmlSerializer
{
internal static SerializationMode Mode { get; set; } = RuntimeFeature.IsDynamicCodeSupported ? SerializationMode.ReflectionAsBackup : SerializationMode.ReflectionOnly;
private static SerializationMode s_mode = SerializationMode.ReflectionAsBackup;

internal static SerializationMode Mode
{
get => RuntimeFeature.IsDynamicCodeSupported ? s_mode : SerializationMode.ReflectionOnly;
set => s_mode = value;
}

private static bool ReflectionMethodEnabled
{
Expand Down