Skip to content

Fix stack overflow reporting from native code #56774

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
janvorli merged 2 commits into from
Aug 4, 2021
Merged

Fix stack overflow reporting from native code #56774

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
46e941f
Fix stack overflow reporting from native code
janvorli Aug 3, 2021
1d99f99
Revert behavior for the Windows x86 case
janvorli Aug 3, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions src/coreclr/vm/eepolicy.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -629,7 +629,13 @@ void DECLSPEC_NORETURN EEPolicy::HandleFatalStackOverflow(EXCEPTION_POINTERS *pE
if (pExceptionInfo && pExceptionInfo->ContextRecord)
{
GCX_COOP();
#if defined(TARGET_X86) && defined(TARGET_WINDOWS)
// For Windows x86, we don't have a reliable method to unwind to the first managed call frame,
// so we handle at least the cases when the stack overflow happens in JIT helpers
AdjustContextForJITHelpers(pExceptionInfo->ExceptionRecord, pExceptionInfo->ContextRecord);
#else
Thread::VirtualUnwindToFirstManagedCallFrame(pExceptionInfo->ContextRecord);
#endif
fef.InitAndLink(pExceptionInfo->ContextRecord);
}

Expand Down