Skip to content

disable token info in traces. #56780

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mangod9 merged 2 commits into from
Aug 4, 2021
Merged

disable token info in traces. #56780

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6b015b5
disable token info in traces.
mangod9 Aug 3, 2021
9ce84cd
fix build break due to whitespace in comment.
mangod9 Aug 3, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
disable token info in traces. 
Though token+offset is useful for certain scenarios, they might not be usable for majority of scenarios. So disabling them by default.
  • Loading branch information
@mangod9
mangod9 committed Aug 3, 2021
commit 6b015b5c7cc888e448121f13ad3198fc06a65cd0
3 changes: 2 additions & 1 deletion src/libraries/System.Private.CoreLib/src/System/LocalAppContextSwitches.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,8 @@ private static bool GetDefaultShowILOffsetSetting()
if (s_showILOffset < 0) return false;
if (s_showILOffset > 0) return true;

bool isSwitchEnabled = AppContextConfigHelper.GetBooleanConfig("Switch.System.Diagnostics.StackTrace.ShowILOffsets", true);
// Disabled by default.
bool isSwitchEnabled = AppContextConfigHelper.GetBooleanConfig("Switch.System.Diagnostics.StackTrace.ShowILOffsets", false);
s_showILOffset = isSwitchEnabled ? 1 : -1;

return isSwitchEnabled;
Expand Down