Skip to content

Forbid fgMorphCommutative during optValnumCSE_phase #57160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
echesakov merged 6 commits into from
Aug 17, 2021
Merged

Forbid fgMorphCommutative during optValnumCSE_phase #57160

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
c34f64b
Add regression test for https://github.com/dotnet/runtime/issues/56935
echesakov Aug 10, 2021
a7700f5
Forbid fgMorphCommutative() during optValnumCSE_phase in src/coreclr/…
echesakov Aug 10, 2021
ff5dd1a
Remove redundant condition in fgMorphCommutative() in src/coreclr/jit…
echesakov Aug 10, 2021
109e2c8
Address feedback:
echesakov Aug 14, 2021
0e736c6
Address feedback:
echesakov Aug 16, 2021
80202a6
Apply nits
echesakov Aug 17, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Apply nits
  • Loading branch information
@echesakov
echesakov committed Aug 17, 2021
commit 80202a672ac88d1031865dad2481021107ecd3da
4 changes: 3 additions & 1 deletion src/coreclr/jit/morph.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11011,11 +11011,13 @@ GenTree* Compiler::fgMorphCommutative(GenTreeOp* tree)

auto foldedCns = folded->AsIntCon();

cns1->SetIconValue(foldedCns->gtIconVal);
cns1->SetIconValue(foldedCns->IconValue());
cns1->SetVNsFromNode(foldedCns);

if (oper == GT_ADD)
{
// Note that gtFoldExprConst doesn't maintain fieldSeq when folding constant
// trees of TYP_LONG.
cns1->gtFieldSeq = GetFieldSeqStore()->Append(cns1->gtFieldSeq, cns2->gtFieldSeq);
}

Expand Down